Bug 185230 - Use IOSurfaces for CoreImage operations where possible
Summary: Use IOSurfaces for CoreImage operations where possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-02 17:41 PDT by Dean Jackson
Modified: 2018-05-04 17:27 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.83 KB, patch)
2018-05-02 17:45 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (6.13 KB, patch)
2018-05-04 16:49 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (6.19 KB, patch)
2018-05-04 16:59 PDT, Dean Jackson
jonlee: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-05-02 17:41:27 PDT
Use IOSurfaces for CoreImage operations where possible
Comment 1 Radar WebKit Bug Importer 2018-05-02 17:41:56 PDT
<rdar://problem/39926929>
Comment 2 Dean Jackson 2018-05-02 17:45:29 PDT
Created attachment 339371 [details]
Patch
Comment 3 Jon Lee 2018-05-04 11:44:58 PDT
Comment on attachment 339371 [details]
Patch

A new patch will be uploaded to address some offline comments.
Comment 4 Dean Jackson 2018-05-04 16:49:09 PDT
Created attachment 339613 [details]
Patch
Comment 5 EWS Watchlist 2018-05-04 16:50:32 PDT
Attachment 339613 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderThemeIOS.h:34:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Dean Jackson 2018-05-04 16:54:35 PDT
oops already fixed include order
Comment 7 Dean Jackson 2018-05-04 16:59:10 PDT
Created attachment 339614 [details]
Patch
Comment 8 Dean Jackson 2018-05-04 17:27:11 PDT
Committed r231394: <https://trac.webkit.org/changeset/231394>