Bug 185229 - REGRESSION(r231251): __cpp_lib_optional should be used after including <optional> since it is defined in <optional> (Requested by yusukesuzuki on #webkit).
Summary: REGRESSION(r231251): __cpp_lib_optional should be used after including <optio...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
Keywords: InRadar
Depends on:
Blocks: 185159
  Show dependency treegraph
Reported: 2018-05-02 17:26 PDT by WebKit Commit Bot
Modified: 2018-05-02 17:29 PDT (History)
3 users (show)

See Also:

ROLLOUT of r231251 (1.35 KB, patch)
2018-05-02 17:26 PDT, WebKit Commit Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2018-05-02 17:26:39 PDT
https://trac.webkit.org/changeset/231251 broke the build:
__cpp_lib_optional should be used after including <optional> since it is defined in <optional> (Requested by yusukesuzuki on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2018-05-02 17:26:44 PDT
Created attachment 339370 [details]
ROLLOUT of r231251

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2018-05-02 17:28:32 PDT
Comment on attachment 339370 [details]
ROLLOUT of r231251

Clearing flags on attachment: 339370

Committed r231281: <https://trac.webkit.org/changeset/231281>
Comment 3 WebKit Commit Bot 2018-05-02 17:28:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-05-02 17:29:20 PDT