Bug 185227 - Remove superfluous check for a null attribute value check in Element::removeAttributeInternal
Summary: Remove superfluous check for a null attribute value check in Element::removeA...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-02 16:47 PDT by Ryosuke Niwa
Modified: 2018-05-02 20:41 PDT (History)
9 users (show)

See Also:

Attachments
Removes the code (1.38 KB, patch)
2018-05-02 16:59 PDT, Ryosuke Niwa 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-05-02 16:47:37 PDT 
Element::removeAttributeInternal has a check for valueBeingRemoved.isNull() before calling willModifyAttribute.
But this is impossible because attribute value is always empty string or a string of at least length 1.
Comment 1 Ryosuke Niwa 2018-05-02 16:59:17 PDT 
Created attachment 339365 [details]
Removes the code
Comment 2 Ryosuke Niwa 2018-05-02 20:40:31 PDT 
Committed r231294: <https://trac.webkit.org/changeset/231294>
Comment 3 Radar WebKit Bug Importer 2018-05-02 20:41:25 PDT 
<rdar://problem/39930646>