Bug 185226 - Remove the prototype caching for get_by_id in the LLInt
Summary: Remove the prototype caching for get_by_id in the LLInt
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on: 185564
Blocks:
  Show dependency tree / graph
 
Reported: 2018-05-02 16:03 PDT by Keith Miller
Modified: 2018-08-31 10:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (34.26 KB, patch)
2018-05-02 16:10 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (34.90 KB, patch)
2018-05-03 10:28 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-05-02 16:03:44 PDT 
Remove the prototype caching for get_by_id in the LLInt
Comment 1 Keith Miller 2018-05-02 16:10:52 PDT 
Created attachment 339363 [details]
Patch
Comment 2 Keith Miller 2018-05-03 10:28:23 PDT 
Created attachment 339424 [details]
Patch
Comment 3 Michael Saboff 2018-05-03 10:36:47 PDT 
Comment on attachment 339424 [details]
Patch

r=me
Comment 4 Keith Miller 2018-05-03 10:40:02 PDT 
rdar://problem/39104634
Comment 5 WebKit Commit Bot 2018-05-03 11:18:41 PDT 
Comment on attachment 339424 [details]
Patch

Clearing flags on attachment: 339424

Committed r231316: <https://trac.webkit.org/changeset/231316>
Comment 6 WebKit Commit Bot 2018-05-03 11:18:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Keith Miller 2018-05-03 17:04:16 PDT 
32-bit fix in https://trac.webkit.org/r231332.
Comment 8 WebKit Commit Bot 2018-05-11 14:13:24 PDT 
Re-opened since this is blocked by bug 185564
Comment 9 Keith Miller 2018-06-06 16:54:52 PDT 
We are not gonna do this since it turns out this matters.
Comment 10 Mark Lam 2018-08-30 22:43:14 PDT 
*** Bug 187754 has been marked as a duplicate of this bug. ***
Comment 11 Mark Lam 2018-08-31 10:13:08 PDT 
For the record, ...

(In reply to Keith Miller from comment #9)
> We are not gonna do this since it turns out this matters.

... means this patch was rolled out in https://bugs.webkit.org/show_bug.cgi?id=185564, i.e. r231719: <https://trac.webkit.org/changeset/231719>.