Create analysis task should sync analysis task status after creation.
https://bugs.webkit.org/show_bug.cgi?id=185222
Summary Create analysis task should sync analysis task status after creation.
dewei_zhu
Reported 2018-05-02 15:28:41 PDT
Create analysis task should sync analysis task status after creation.
Attachments
Patch (12.73 KB, patch)
2018-05-02 15:33 PDT, dewei_zhu
rniwa: review+
dewei_zhu
Comment 1 2018-05-02 15:33:08 PDT
Ryosuke Niwa
Comment 2 2018-05-02 20:42:49 PDT
Comment on attachment 339359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339359&action=review > Websites/perf.webkit.org/unit-tests/analysis-task-tests.js:327 > + it('should sync the new analysis task status onceit is created', async () => { Nit: Need a space between "once" and "it". > Websites/perf.webkit.org/unit-tests/analysis-task-tests.js:386 > + }); Please add another test where the creation of an analysis fails and a rejected promise is returned (as opposed to throwing an exception).
Note You need to log in before you can comment on or make changes to this bug.