Bug 185222 - Create analysis task should sync analysis task status after creation.
Summary: Create analysis task should sync analysis task status after creation.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-02 15:28 PDT by dewei_zhu
Modified: 2018-05-02 20:42 PDT (History)
2 users (show)

See Also:

Attachments
Patch (12.73 KB, patch)
2018-05-02 15:33 PDT, dewei_zhu 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2018-05-02 15:28:41 PDT 
Create analysis task should sync analysis task status after creation.
Comment 1 dewei_zhu 2018-05-02 15:33:08 PDT 
Created attachment 339359 [details]
Patch
Comment 2 Ryosuke Niwa 2018-05-02 20:42:49 PDT 
Comment on attachment 339359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339359&action=review

> Websites/perf.webkit.org/unit-tests/analysis-task-tests.js:327
> +        it('should sync the new analysis task status onceit is created', async () => {

Nit: Need a space between "once" and "it".

> Websites/perf.webkit.org/unit-tests/analysis-task-tests.js:386
> +        });

Please add another test where the creation of an analysis fails and a rejected promise is returned (as opposed to throwing an exception).