Bug 185215 - The generateConditionsForPropertyBlah API should have a nicer handling of custom accessors
Summary: The generateConditionsForPropertyBlah API should have a nicer handling of cus...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-02 13:59 PDT by Filip Pizlo
Modified: 2018-05-02 13:59 PDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2018-05-02 13:59:04 PDT
This code smells funny:

if (!slot.isCacheableCustom()) {
    conditionSet = generateConditionsForPrototypePropertyHit(
        vm, codeBlock, exec, structure, slot.slotBase(),
        propertyName.impl());
} else {
    conditionSet = generateConditionsForPrototypePropertyHitCustom(
        vm, codeBlock, exec, structure, slot.slotBase(),
        propertyName.impl());
}

Maybe the `if` should be inside generateConditionsForPrototypePropertyHit.