Bug 185215 – The generateConditionsForPropertyBlah API should have a nicer handling of custom accessors

• Status: NEW
• Component: JavaScriptCore

[Filip Pizlo]

This code smells funny:

if (!slot.isCacheableCustom()) {
    conditionSet = generateConditionsForPrototypePropertyHit(
        vm, codeBlock, exec, structure, slot.slotBase(),
        propertyName.impl());
} else {
    conditionSet = generateConditionsForPrototypePropertyHitCustom(
        vm, codeBlock, exec, structure, slot.slotBase(),
        propertyName.impl());
}

Maybe the `if` should be inside generateConditionsForPrototypePropertyHit.