Bug 185202 - test262/Runner.pm: performance improvements
Summary: test262/Runner.pm: performance improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: valerie
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-02 09:38 PDT by valerie
Modified: 2018-05-03 09:52 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.88 KB, patch)
2018-05-02 12:47 PDT, valerie
no flags Details | Formatted Diff | Diff
Expand info in changelog (459 bytes, patch)
2018-05-02 13:53 PDT, valerie
no flags Details | Formatted Diff | Diff
Patch (6.07 KB, patch)
2018-05-02 14:07 PDT, valerie
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description valerie 2018-05-02 09:38:16 PDT
In this patch:
- Fix bug in use of parallelization
- Only parallelize when there are an appropriate numbers of tests to run
Comment 1 valerie 2018-05-02 12:47:18 PDT
Created attachment 339326 [details]
Patch
Comment 2 Michael Saboff 2018-05-02 13:35:29 PDT
Comment on attachment 339326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339326&action=review

r=me.

Please add the requested description text tot the change log.

> Tools/ChangeLog:7
> +

Add a description that details the changes at a high level.  Include reasons for the change, if approriate.
Comment 3 valerie 2018-05-02 13:53:36 PDT
Created attachment 339332 [details]
Expand info in changelog
Comment 4 EWS Watchlist 2018-05-02 13:54:45 PDT
Attachment 339332 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:32:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 valerie 2018-05-02 14:07:17 PDT
Created attachment 339335 [details]
Patch
Comment 6 Michael Saboff 2018-05-02 14:15:05 PDT
Comment on attachment 339335 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2018-05-03 09:52:33 PDT
Comment on attachment 339335 [details]
Patch

Clearing flags on attachment: 339335

Committed r231309: <https://trac.webkit.org/changeset/231309>
Comment 8 WebKit Commit Bot 2018-05-03 09:52:35 PDT
All reviewed patches have been landed.  Closing bug.