Bug 185199 - [iOS] Provide audio route information when invoking AirPlay picker
Summary: [iOS] Provide audio route information when invoking AirPlay picker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-02 08:44 PDT by Eric Carlson
Modified: 2018-05-03 13:39 PDT (History)
6 users (show)

See Also:

Attachments
Patch (33.25 KB, patch)
2018-05-02 09:06 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (33.91 KB, patch)
2018-05-02 09:45 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (33.95 KB, patch)
2018-05-02 10:05 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (1.83 KB, patch)
2018-05-02 12:47 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Another attempted build fix (1.35 KB, patch)
2018-05-02 14:09 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Another attempted build fix (1.36 KB, patch)
2018-05-02 14:35 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Another build fix (1.50 KB, patch)
2018-05-03 13:20 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-05-02 08:44:55 PDT 
Provide audio route information when invoking AirPlay picker
Comment 1 Eric Carlson 2018-05-02 08:45:26 PDT 
<rdar://problem/39853103>
Comment 2 Eric Carlson 2018-05-02 09:06:33 PDT 
Created attachment 339305 [details]
Patch
Comment 3 EWS Watchlist 2018-05-02 09:16:11 PDT 
Attachment 339305 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/AudioSession.cpp:117:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Jon Lee 2018-05-02 09:36:19 PDT 
Comment on attachment 339305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339305&action=review

> Source/WebCore/platform/audio/AudioSession.cpp:116
> +String AudioSession::routingContextUID const

missing ()!
Comment 5 Eric Carlson 2018-05-02 09:45:52 PDT 
Created attachment 339308 [details]
Patch
Comment 6 EWS Watchlist 2018-05-02 09:47:24 PDT 
Attachment 339308 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/mac/AudioSessionMac.cpp:135:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/audio/AudioSession.cpp:117:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Eric Carlson 2018-05-02 10:05:02 PDT 
Created attachment 339312 [details]
Patch
Comment 8 WebKit Commit Bot 2018-05-02 10:51:51 PDT 
Comment on attachment 339312 [details]
Patch

Clearing flags on attachment: 339312

Committed r231242: <https://trac.webkit.org/changeset/231242>
Comment 9 WebKit Commit Bot 2018-05-02 10:51:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Ryan Haddad 2018-05-02 11:39:16 PDT 
This change broke the iOS build:

/Volumes/Data/slave/ios-11-release/build/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:182:45: error: instance method '-routingContextUID' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]

https://build.webkit.org/builders/Apple%20iOS%2011%20Release%20%28Build%29/builds/5825
Comment 11 Eric Carlson 2018-05-02 12:47:15 PDT 
Reopening to attach new patch.
Comment 12 Eric Carlson 2018-05-02 12:47:15 PDT 
Created attachment 339325 [details]
Patch
Comment 13 WebKit Commit Bot 2018-05-02 13:26:37 PDT 
Comment on attachment 339325 [details]
Patch

Clearing flags on attachment: 339325

Committed r231258: <https://trac.webkit.org/changeset/231258>
Comment 14 WebKit Commit Bot 2018-05-02 13:26:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 15 Eric Carlson 2018-05-02 14:09:37 PDT 
Reopening to attach new patch.
Comment 16 Eric Carlson 2018-05-02 14:09:38 PDT 
Created attachment 339336 [details]
Another attempted build fix
Comment 17 WebKit Commit Bot 2018-05-02 14:14:00 PDT 
Comment on attachment 339336 [details]
Another attempted build fix

Rejecting attachment 339336 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 339336, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/PAL/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/7541804
Comment 18 Eric Carlson 2018-05-02 14:35:40 PDT 
Created attachment 339342 [details]
Another attempted build fix
Comment 19 WebKit Commit Bot 2018-05-02 16:08:26 PDT 
Comment on attachment 339342 [details]
Another attempted build fix

Clearing flags on attachment: 339342

Committed r231278: <https://trac.webkit.org/changeset/231278>
Comment 20 WebKit Commit Bot 2018-05-02 16:08:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 21 Eric Carlson 2018-05-03 13:20:05 PDT 
Reopening to attach new patch.
Comment 22 Eric Carlson 2018-05-03 13:20:05 PDT 
Created attachment 339449 [details]
Another build fix
Comment 23 WebKit Commit Bot 2018-05-03 13:39:39 PDT 
Comment on attachment 339449 [details]
Another build fix

Clearing flags on attachment: 339449

Committed r231324: <https://trac.webkit.org/changeset/231324>
Comment 24 WebKit Commit Bot 2018-05-03 13:39:41 PDT 
All reviewed patches have been landed.  Closing bug.