Bug 185192 - [JSC] Add compareDouble and compareFloat for ARM64, X86, and X86_64
Summary: [JSC] Add compareDouble and compareFloat for ARM64, X86, and X86_64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-02 02:59 PDT by Yusuke Suzuki
Modified: 2018-05-02 18:03 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.88 KB, patch)
2018-05-02 03:01 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (19.10 KB, patch)
2018-05-02 03:18 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-05-02 02:59:19 PDT 
[JSC] Add compareDouble and compareFloat for ARM64, X86, and X86_64
Comment 1 Yusuke Suzuki 2018-05-02 03:01:29 PDT 
Created attachment 339294 [details]
Patch
Comment 2 Yusuke Suzuki 2018-05-02 03:18:32 PDT 
Created attachment 339295 [details]
Patch
Comment 3 Mark Lam 2018-05-02 10:42:08 PDT 
Comment on attachment 339295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339295&action=review

r=me

> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:4162
> +            return;

Let's make this a RELEASE_ASSERT_NOT_REACHED().
Comment 4 Yusuke Suzuki 2018-05-02 17:44:03 PDT 
Comment on attachment 339295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339295&action=review

>> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:4162
>> +            return;
> 
> Let's make this a RELEASE_ASSERT_NOT_REACHED().

Nice, fixed :)
Comment 5 Yusuke Suzuki 2018-05-02 17:46:14 PDT 
Committed r231285: <https://trac.webkit.org/changeset/231285>
Comment 6 Radar WebKit Bug Importer 2018-05-02 17:47:26 PDT 
<rdar://problem/39927061>
Comment 7 Yusuke Suzuki 2018-05-02 18:03:31 PDT 
Committed r231290: <https://trac.webkit.org/changeset/231290>