Bug 185188 - [JSC] Add MacroAssembler::and16 and store16
Summary: [JSC] Add MacroAssembler::and16 and store16
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-02 00:51 PDT by Yusuke Suzuki
Modified: 2018-05-02 17:54 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.13 KB, patch)
2018-05-02 01:05 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-05-02 00:51:32 PDT 
[JSC] Add MacroAssembler::and16
Comment 1 Yusuke Suzuki 2018-05-02 01:05:03 PDT 
Created attachment 339289 [details]
Patch
Comment 2 Mark Lam 2018-05-02 09:55:39 PDT 
Comment on attachment 339289 [details]
Patch

Sorry, I didn't see this patch before I reviewed and r+'ed https://bugs.webkit.org/show_bug.cgi?id=185196 and https://bugs.webkit.org/show_bug.cgi?id=185195.

r+ anyway for Source/JavaScriptCore/assembler/MacroAssemblerARM.h part.  You'll probably have to remove the ARMv7 and MIPS parts to resolve a conflict before landing.
Comment 3 Yusuke Suzuki 2018-05-02 17:51:54 PDT 
(In reply to Mark Lam from comment #2)
> Comment on attachment 339289 [details]
> Patch
> 
> Sorry, I didn't see this patch before I reviewed and r+'ed
> https://bugs.webkit.org/show_bug.cgi?id=185196 and
> https://bugs.webkit.org/show_bug.cgi?id=185195.
> 
> r+ anyway for Source/JavaScriptCore/assembler/MacroAssemblerARM.h part. 
> You'll probably have to remove the ARMv7 and MIPS parts to resolve a
> conflict before landing.

OK, I'll land ARM traditional part.
Comment 4 Yusuke Suzuki 2018-05-02 17:53:46 PDT 
Committed r231289: <https://trac.webkit.org/changeset/231289>
Comment 5 Radar WebKit Bug Importer 2018-05-02 17:54:21 PDT 
<rdar://problem/39927259>