Bug 185186 - Use pointer instead of std::optional<std::reference_wrapper<>>
Summary: Use pointer instead of std::optional<std::reference_wrapper<>>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 185256
Blocks:
  Show dependency tree / graph
 
Reported: 2018-05-01 22:08 PDT by Yusuke Suzuki
Modified: 2018-05-03 16:34 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.67 KB, patch)
2018-05-01 22:10 PDT, Yusuke Suzuki 		achristensen: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.73 MB, application/zip)
2018-05-02 01:58 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-05-01 22:08:51 PDT 
Use pointer instead of std::optional<std::reference_wrapper<>>
Comment 1 Yusuke Suzuki 2018-05-01 22:10:17 PDT 
Created attachment 339277 [details]
Patch
Comment 2 EWS Watchlist 2018-05-02 01:58:34 PDT 
Comment on attachment 339277 [details]
Patch

Attachment 339277 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7534850

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 3 EWS Watchlist 2018-05-02 01:58:46 PDT 
Created attachment 339292 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Yusuke Suzuki 2018-05-02 17:50:26 PDT 
Committed r231288: <https://trac.webkit.org/changeset/231288>
Comment 5 Radar WebKit Bug Importer 2018-05-02 17:53:05 PDT 
<rdar://problem/39927186>
Comment 6 WebKit Commit Bot 2018-05-03 09:34:32 PDT 
Re-opened since this is blocked by bug 185256
Comment 7 Jonathan Bedard 2018-05-03 10:00:53 PDT 
Rolled out in r231308 because r231223 was rolled out.  See <https://bugs.webkit.org/show_bug.cgi?id=185159> for details.
Comment 8 Yusuke Suzuki 2018-05-03 16:23:09 PDT 
I'll reland this change by changing std::optional<T&> to T*, which does not break anything.
Comment 9 Yusuke Suzuki 2018-05-03 16:34:59 PDT 
Committed r231333: <https://trac.webkit.org/changeset/231333>