Bug 185182 - Pipe volume through PlaybackSessionManager/Proxy.
Summary: Pipe volume through PlaybackSessionManager/Proxy.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-01 21:04 PDT by Jer Noble
Modified: 2018-05-02 08:50 PDT (History)
7 users (show)

See Also:


Attachments
Patch (16.27 KB, patch)
2018-05-01 21:06 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (22.01 KB, patch)
2018-05-01 21:07 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-05-01 21:04:01 PDT
Pipe volume through PlaybackSessionManager/Proxy.
Comment 1 Radar WebKit Bug Importer 2018-05-01 21:06:09 PDT
<rdar://problem/39890630>
Comment 2 Jer Noble 2018-05-01 21:06:53 PDT
Created attachment 339268 [details]
Patch
Comment 3 Jer Noble 2018-05-01 21:07:59 PDT
Created attachment 339269 [details]
Patch
Comment 4 Sam Weinig 2018-05-01 21:56:08 PDT
Comment on attachment 339269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339269&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:621
> +    return m_playbackModel ? m_playbackModel->volume() : false;

Seems weird/wrong to return false here.
Comment 5 Jer Noble 2018-05-01 21:58:38 PDT
Comment on attachment 339269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339269&action=review

>> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:621
>> +    return m_playbackModel ? m_playbackModel->volume() : false;
> 
> Seems weird/wrong to return false here.

Brain fart. Should 0.
Comment 6 WebKit Commit Bot 2018-05-02 08:50:38 PDT
Comment on attachment 339269 [details]
Patch

Clearing flags on attachment: 339269

Committed r231231: <https://trac.webkit.org/changeset/231231>
Comment 7 WebKit Commit Bot 2018-05-02 08:50:40 PDT
All reviewed patches have been landed.  Closing bug.