Bug 185175 - Get the WebKit.framework bundle by asking for WKWebView
Summary: Get the WebKit.framework bundle by asking for WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-01 16:46 PDT by Jer Noble
Modified: 2018-05-02 10:14 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.83 KB, patch)
2018-05-01 16:48 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (4.20 KB, patch)
2018-05-01 17:19 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (20.56 KB, patch)
2018-05-01 17:58 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (5.63 KB, patch)
2018-05-01 21:11 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (5.76 KB, patch)
2018-05-01 21:52 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (5.99 KB, patch)
2018-05-02 08:25 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-05-01 16:46:10 PDT
Get the WebKit.framework bundle by asking for WKWebView
Comment 1 Radar WebKit Bug Importer 2018-05-01 16:47:20 PDT
<rdar://problem/39884149>
Comment 2 Jer Noble 2018-05-01 16:48:15 PDT
Created attachment 339243 [details]
Patch
Comment 3 Tim Horton 2018-05-01 16:53:10 PDT
Comment on attachment 339243 [details]
Patch

What about 32-bit??
Comment 4 Jer Noble 2018-05-01 17:19:10 PDT
Created attachment 339246 [details]
Patch
Comment 5 Tim Horton 2018-05-01 17:22:54 PDT
Comment on attachment 339246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339246&action=review

> Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:57
> +    NSBundle *webKit2Bundle = [NSBundle bundleForClass:NSClassFromString(@"WKWebView")];

Seems like this should be a helper somewhere very global, at some point (that’s what other framework projects seem to do).
Comment 6 Jer Noble 2018-05-01 17:58:42 PDT
Created attachment 339249 [details]
Patch for landing
Comment 7 Jer Noble 2018-05-01 21:11:35 PDT
Created attachment 339270 [details]
Patch for landing
Comment 8 Jer Noble 2018-05-01 21:52:48 PDT
Created attachment 339274 [details]
Patch for landing
Comment 9 Jer Noble 2018-05-02 08:25:27 PDT
Created attachment 339302 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2018-05-02 10:14:16 PDT
Comment on attachment 339302 [details]
Patch for landing

Clearing flags on attachment: 339302

Committed r231239: <https://trac.webkit.org/changeset/231239>
Comment 11 WebKit Commit Bot 2018-05-02 10:14:17 PDT
All reviewed patches have been landed.  Closing bug.