Bug 185164 - webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
Summary: webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-01 08:39 PDT by Jonathan Bedard
Modified: 2018-05-01 13:55 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.55 KB, patch)
2018-05-01 08:49 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.82 MB, application/zip)
2018-05-01 10:29 PDT, EWS Watchlist
no flags Details
Patch (3.48 KB, patch)
2018-05-01 11:40 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-05-01 08:39:43 PDT
Previously, we asserted that SIGKILLing a process right after SIGTERMing it would have not effect because the process should have already processed the SIGTERM and closed if it were going to terminate graciously. Working with 'xcrun simctl spawn' and API tests which timeout, however, this observation is not correct. When 'xcrun simctl spawn' receives a SIGKILL right after a SIGTERM, it will not propagate the SIGTERM to it's child process, leaving an orphaned process.
Comment 1 Jonathan Bedard 2018-05-01 08:49:54 PDT
Created attachment 339199 [details]
Patch
Comment 2 Jonathan Bedard 2018-05-01 08:54:43 PDT
This hasn't bit us yet, but the moment someone commits an iOS test which times out, it will.
Comment 3 David Kilzer (:ddkilzer) 2018-05-01 09:13:59 PDT
Comment on attachment 339199 [details]
Patch

r=me
Comment 4 Jonathan Bedard 2018-05-01 09:15:47 PDT
Comment on attachment 339199 [details]
Patch

Going to wait for EWS since I only tested iOS API tests, and this code path is used by everything for layout tests.
Comment 5 EWS Watchlist 2018-05-01 10:29:36 PDT
Comment on attachment 339199 [details]
Patch

Attachment 339199 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7525427

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
Comment 6 EWS Watchlist 2018-05-01 10:29:48 PDT
Created attachment 339203 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 Jonathan Bedard 2018-05-01 11:40:27 PDT
Created attachment 339207 [details]
Patch
Comment 8 WebKit Commit Bot 2018-05-01 13:53:39 PDT
Comment on attachment 339207 [details]
Patch

Clearing flags on attachment: 339207

Committed r231209: <https://trac.webkit.org/changeset/231209>
Comment 9 WebKit Commit Bot 2018-05-01 13:53:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-05-01 13:55:18 PDT
<rdar://problem/39877451>