185150 – [Apple Pay] Allow $0 totals

Bug 185150 - [Apple Pay] Allow $0 totals

Summary: [Apple Pay] Allow $0 totals

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Andy Estes

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2018-04-30 16:21 PDT by Andy Estes
Modified:	2018-08-24 08:20 PDT (History)
CC List:	10 users (show)

See Also:

Attachments
Patch (10.32 KB, patch) 2018-04-30 16:25 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews206 for win-future (12.76 MB, application/zip) 2018-04-30 20:42 PDT, EWS Watchlist	no flags	Details
Patch (12.78 KB, patch) 2018-08-23 17:07 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (13.88 KB, patch) 2018-08-24 07:37 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (13.88 KB, patch) 2018-08-24 07:42 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andy Estes 2018-04-30 16:21:59 PDT

[Apple Pay] Allow $0 totals

Comment 1 Andy Estes 2018-04-30 16:22:41 PDT

rdar://problem/39212331

Comment 2 Andy Estes 2018-04-30 16:25:06 PDT Comment hidden (obsolete)

Created attachment 339160 [details]
Patch

Comment 3 Tim Horton 2018-04-30 16:37:58 PDT

Comment on attachment 339160 [details]
Patch

Is there a spec change to reference?

Comment 4 Andy Estes 2018-04-30 16:39:04 PDT

(In reply to Tim Horton from comment #3)
> Comment on attachment 339160 [details]
> Patch
> 
> Is there a spec change to reference?

No spec change. Payment Request has always allowed this, but we had an Apple Pay-specific restriction that we're now relaxing. Lots of justification for why in rdar://problem/39212331.

Comment 5 Andy Estes 2018-04-30 16:46:10 PDT

Alex pointed out that I need to add OS version checks, and he's right!

Comment 6 EWS Watchlist 2018-04-30 20:42:28 PDT Comment hidden (obsolete)

Comment on attachment 339160 [details]
Patch

Attachment 339160 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7518445

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

Comment 7 EWS Watchlist 2018-04-30 20:42:39 PDT Comment hidden (obsolete)

Created attachment 339178 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Comment 8 Andy Estes 2018-08-23 17:07:44 PDT

Created attachment 347976 [details]
Patch

Comment 9 Andy Estes 2018-08-23 17:08:46 PDT

(In reply to Andy Estes from comment #5)
> Alex pointed out that I need to add OS version checks, and he's right!

The version number was bumped in r235251, so clients can use this to check if $0 totals are supported.

Comment 10 Andy Estes 2018-08-24 07:37:23 PDT Comment hidden (obsolete)

Created attachment 348008 [details]
Patch

Comment 11 WebKit Commit Bot 2018-08-24 07:40:01 PDT Comment hidden (obsolete)

Comment on attachment 348008 [details]
Patch

Rejecting attachment 348008 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 348008, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/8971625

Comment 12 Andy Estes 2018-08-24 07:42:08 PDT

Created attachment 348009 [details]
Patch

Comment 13 WebKit Commit Bot 2018-08-24 08:20:56 PDT

Comment on attachment 348009 [details]
Patch

Clearing flags on attachment: 348009

Committed r235318: <https://trac.webkit.org/changeset/235318>

Comment 14 WebKit Commit Bot 2018-08-24 08:20:58 PDT

All reviewed patches have been landed.  Closing bug.