Bug 185150 – [Apple Pay] Allow $0 totals

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Apple Pay] Allow $0 totals

[Andy Estes]

rdar://problem/39212331

[Andy Estes]

Created attachment 339160 [details]
Patch

[Tim Horton]

Comment on attachment 339160 [details]
Patch

Is there a spec change to reference?

[Andy Estes]

(In reply to Tim Horton from comment #3)
> Comment on attachment 339160 [details]
> Patch
> 
> Is there a spec change to reference?

No spec change. Payment Request has always allowed this, but we had an Apple Pay-specific restriction that we're now relaxing. Lots of justification for why in rdar://problem/39212331.

[Andy Estes]

Alex pointed out that I need to add OS version checks, and he's right!

[EWS Watchlist]

Comment on attachment 339160 [details]
Patch

Attachment 339160 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7518445

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 339178 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Andy Estes]

Created attachment 347976 [details]
Patch

[Andy Estes]

(In reply to Andy Estes from comment #5)
> Alex pointed out that I need to add OS version checks, and he's right!

The version number was bumped in r235251, so clients can use this to check if $0 totals are supported.

[Andy Estes]

Created attachment 348008 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 348008 [details]
Patch

Rejecting attachment 348008 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 348008, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/8971625

[Andy Estes]

Created attachment 348009 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 348009 [details]
Patch

Clearing flags on attachment: 348009

Committed r235318: <https://trac.webkit.org/changeset/235318>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.