Bug 185147 – Eliminate WebProcessShim.dylib

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Michael Saboff]

This shim library contains WebKit/Shared/mac/CookieStorageShimLibrary.cpp and SecItemShim code.  The Cookie Storage Shim library is being removed in <https://bugs.webkit.org/show_bug.cgi?id=185146> "Remove unused mac/CookieStorageShimLibrary".  This bug is to eliminate the creation and use of WebProcessShim.dylib as the WebContent process doesn't reference any of the APIs in the WebProcessShim library.  The SecItemShim code is still referenced by the Network process, but that is done via SecItemShim.dylib.

[Michael Saboff]

Created attachment 339155 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 339155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339155&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:-11908
> -			baseConfigurationReference = A1EDD2DD1884B9E300BBFE98 /* WebProcessShim.xcconfig */;

The WebProcessShim.xcconfig file can be now removed too I think.

[Michael Saboff]

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 339155 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339155&action=review
> 
> > Source/WebKit/WebKit.xcodeproj/project.pbxproj:-11908
> > -			baseConfigurationReference = A1EDD2DD1884B9E300BBFE98 /* WebProcessShim.xcconfig */;
> 
> The WebProcessShim.xcconfig file can be now removed too I think.

Yup.  I'll do that before landing.

[EWS Watchlist]

Comment on attachment 339155 [details]
Patch

Attachment 339155 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7517050

New failing tests:
http/tests/misc/resource-timing-resolution.html

[EWS Watchlist]

Created attachment 339166 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Michael Saboff]

Committed r231190: <https://trac.webkit.org/changeset/231190>

[Radar WebKit Bug Importer]

<rdar://problem/39857210>