Bug 185143 - Move the MayBePrototype JSCell header bit to InlineTypeFlags
Summary: Move the MayBePrototype JSCell header bit to InlineTypeFlags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-30 14:57 PDT by Keith Miller
Modified: 2021-11-01 12:06 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.74 KB, patch)
2018-04-30 14:58 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (5.21 KB, patch)
2018-04-30 15:10 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-04-30 14:57:46 PDT 
Move the MayBePrototype JSCell header bit to InlineTypeFlags
Comment 1 Keith Miller 2018-04-30 14:58:05 PDT 
Created attachment 339150 [details]
Patch
Comment 2 Mark Lam 2018-04-30 15:06:18 PDT 
Comment on attachment 339150 [details]
Patch

r=me
Comment 3 Keith Miller 2018-04-30 15:09:55 PDT 
Comment on attachment 339150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339150&action=review

> Source/JavaScriptCore/runtime/JSCellInlines.h:234
> +    m_flags = structure->typeInfo().inlineTypeFlags() | (m_flags & static_cast<TypeInfo::InlineTypeFlags>(TypeInfoMayBePrototype));

I actually turned this into a function in TypeInfo since it seems a bit cleaner, are you ok with that change?
Comment 4 Mark Lam 2018-04-30 15:10:54 PDT 
(In reply to Keith Miller from comment #3)
> Comment on attachment 339150 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339150&action=review
> 
> > Source/JavaScriptCore/runtime/JSCellInlines.h:234
> > +    m_flags = structure->typeInfo().inlineTypeFlags() | (m_flags & static_cast<TypeInfo::InlineTypeFlags>(TypeInfoMayBePrototype));
> 
> I actually turned this into a function in TypeInfo since it seems a bit
> cleaner, are you ok with that change?

Sounds good.
Comment 5 Keith Miller 2018-04-30 15:10:57 PDT 
Created attachment 339152 [details]
Patch
Comment 6 Keith Miller 2018-04-30 15:13:19 PDT 
Committed r231172: <https://trac.webkit.org/changeset/231172>
Comment 7 Radar WebKit Bug Importer 2018-04-30 15:14:39 PDT 
<rdar://problem/39850745>
Comment 8 Alex Christensen 2021-11-01 12:06:40 PDT 
Comment on attachment 339152 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.