Bug 185143 – Move the MayBePrototype JSCell header bit to InlineTypeFlags

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

Move the MayBePrototype JSCell header bit to InlineTypeFlags

[Keith Miller]

Created attachment 339150 [details]
Patch

[Mark Lam]

Comment on attachment 339150 [details]
Patch

r=me

[Keith Miller]

Comment on attachment 339150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339150&action=review

> Source/JavaScriptCore/runtime/JSCellInlines.h:234
> +    m_flags = structure->typeInfo().inlineTypeFlags() | (m_flags & static_cast<TypeInfo::InlineTypeFlags>(TypeInfoMayBePrototype));

I actually turned this into a function in TypeInfo since it seems a bit cleaner, are you ok with that change?

[Mark Lam]

(In reply to Keith Miller from comment #3)
> Comment on attachment 339150 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339150&action=review
> 
> > Source/JavaScriptCore/runtime/JSCellInlines.h:234
> > +    m_flags = structure->typeInfo().inlineTypeFlags() | (m_flags & static_cast<TypeInfo::InlineTypeFlags>(TypeInfoMayBePrototype));
> 
> I actually turned this into a function in TypeInfo since it seems a bit
> cleaner, are you ok with that change?

Sounds good.

[Keith Miller]

Created attachment 339152 [details]
Patch

[Keith Miller]

Committed r231172: <https://trac.webkit.org/changeset/231172>

[Radar WebKit Bug Importer]

<rdar://problem/39850745>

[Alex Christensen]

Comment on attachment 339152 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.