Bug 185140 – WebProcess fails to launch

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Per Arne Vollan]

The macOS target version should be used to determine the runloop type.

[Per Arne Vollan]

<rdar://problem/39585037>

[Per Arne Vollan]

Created attachment 339133 [details]
Patch

[Brent Fulgham]

Comment on attachment 339133 [details]
Patch

Looks good. r=me.

[Per Arne Vollan]

Comment on attachment 339133 [details]
Patch

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 339133 [details]
Patch

Clearing flags on attachment: 339133

Committed r231192: <https://trac.webkit.org/changeset/231192>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

Comment on attachment 339133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339133&action=review

> Source/WebKit/Configurations/WebContentService.xcconfig:64
> +RUNLOOP_TYPE = $(RUNLOOP_TYPE_$(PLATFORM_NAME)_$(TARGET_MAC_OS_X_VERSION_MAJOR));

We avoid using TARGET_MAC_OS_X_VERSION_MAJOR like this because it’s not future-proof. Please use the WK_MACOS_* machinery defined in WebKitTargetConditionals.xcconfig as described in the comments there.

[Per Arne Vollan]

Reopening to attach new patch.

[Per Arne Vollan]

Created attachment 339204 [details]
Patch

[Per Arne Vollan]

(In reply to mitz from comment #7)
> Comment on attachment 339133 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339133&action=review
> 
> > Source/WebKit/Configurations/WebContentService.xcconfig:64
> > +RUNLOOP_TYPE = $(RUNLOOP_TYPE_$(PLATFORM_NAME)_$(TARGET_MAC_OS_X_VERSION_MAJOR));
> 
> We avoid using TARGET_MAC_OS_X_VERSION_MAJOR like this because it’s not
> future-proof. Please use the WK_MACOS_* machinery defined in
> WebKitTargetConditionals.xcconfig as described in the comments there.

Thanks! I have updated the patch.

[Brent Fulgham]

Comment on attachment 339204 [details]
Patch

Very cool! r=me

[EWS Watchlist]

Comment on attachment 339204 [details]
Patch

Attachment 339204 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7526510

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
fast/dom/URL-attribute-reflection.html
http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html

[EWS Watchlist]

Created attachment 339213 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[WebKit Commit Bot]

Comment on attachment 339204 [details]
Patch

Clearing flags on attachment: 339204

Committed r231205: <https://trac.webkit.org/changeset/231205>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Per Arne Vollan]

This is still a problem.

[Per Arne Vollan]

Created attachment 340727 [details]
Patch

[Geoffrey Garen]

Comment on attachment 340727 [details]
Patch

r=me

Can we test this -- or is it observable in an existing crash?

[WebKit Commit Bot]

Comment on attachment 340727 [details]
Patch

Clearing flags on attachment: 340727

Committed r231984: <https://trac.webkit.org/changeset/231984>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.