Bug 185136 - [MediaStream] remove WK1 support
Summary: [MediaStream] remove WK1 support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-30 09:59 PDT by Eric Carlson
Modified: 2018-05-01 10:28 PDT (History)
5 users (show)

See Also:


Attachments
Patch (34.36 KB, text/plain)
2018-04-30 10:03 PDT, Eric Carlson
youennf: review+
ews-watchlist: commit-queue-
Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.64 MB, application/zip)
2018-04-30 10:47 PDT, EWS Watchlist
no flags Details
Patch (23.39 KB, patch)
2018-04-30 14:42 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.49 MB, application/zip)
2018-04-30 15:53 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews112 for mac-sierra (3.13 MB, application/zip)
2018-04-30 16:27 PDT, EWS Watchlist
no flags Details
Patch (23.99 KB, patch)
2018-05-01 09:20 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-04-30 09:59:12 PDT
getUserMedia has never worked in webKit1 and we don't plan to add support, so remove all of the WK1-only code.
Comment 1 Eric Carlson 2018-04-30 10:03:06 PDT
Created attachment 339120 [details]
Patch
Comment 2 youenn fablet 2018-04-30 10:18:29 PDT
Comment on attachment 339120 [details]
Patch

r=me once the bots are happy.

View in context: https://bugs.webkit.org/attachment.cgi?id=339120&action=review

> Source/WebKitLegacy/mac/WebView/WebView.mm:3038
> +    DeprecatedGlobalSettings::setMediaCaptureRequiresSecureConnection(true);

These two are probably not needed since the below runtime flags are set to false.
Comment 3 EWS Watchlist 2018-04-30 10:47:58 PDT
Comment on attachment 339120 [details]
Patch

Attachment 339120 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7508903

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2018-04-30 10:47:59 PDT
Created attachment 339126 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 Eric Carlson 2018-04-30 14:42:14 PDT
Created attachment 339148 [details]
Patch
Comment 6 EWS Watchlist 2018-04-30 15:53:36 PDT
Comment on attachment 339148 [details]
Patch

Attachment 339148 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7516049

New failing tests:
fast/events/constructors/media-stream-event-constructor.html
Comment 7 EWS Watchlist 2018-04-30 15:53:37 PDT
Created attachment 339157 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-04-30 16:27:54 PDT
Comment on attachment 339148 [details]
Patch

Attachment 339148 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7516207

New failing tests:
fast/events/constructors/media-stream-event-constructor.html
Comment 9 EWS Watchlist 2018-04-30 16:27:55 PDT
Created attachment 339161 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 Eric Carlson 2018-05-01 09:20:53 PDT
Created attachment 339201 [details]
Patch
Comment 11 WebKit Commit Bot 2018-05-01 10:27:18 PDT
Comment on attachment 339201 [details]
Patch

Clearing flags on attachment: 339201

Committed r231201: <https://trac.webkit.org/changeset/231201>
Comment 12 WebKit Commit Bot 2018-05-01 10:27:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2018-05-01 10:28:42 PDT
<rdar://problem/39870021>