Bug 185129 - Make color-filter affect caret-color
Summary: Make color-filter affect caret-color
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-29 21:58 PDT by Simon Fraser (smfr)
Modified: 2018-05-01 12:48 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.73 KB, patch)
2018-04-29 22:00 PDT, Simon Fraser (smfr) 		thorton: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.22 MB, application/zip)
2018-04-29 23:38 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-04-29 21:58:38 PDT 
Make color-filter affect caret-color
Comment 1 Simon Fraser (smfr) 2018-04-29 22:00:59 PDT 
Created attachment 339105 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-04-29 22:01:24 PDT 
rdar://problem/39829066
Comment 3 Simon Fraser (smfr) 2018-04-29 22:02:37 PDT 
Dan, I noticed that we fail imported/w3c/web-platform-tests/css/css-ui/caret-color-006.html
Comment 4 Daniel Bates 2018-04-29 22:34:43 PDT 
(In reply to Simon Fraser (smfr) from comment #3)
> Dan, I noticed that we fail
> imported/w3c/web-platform-tests/css/css-ui/caret-color-006.html

Please file a bug.
Comment 5 EWS Watchlist 2018-04-29 23:38:58 PDT 
Comment on attachment 339105 [details]
Patch

Attachment 339105 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7504518

New failing tests:
css3/color-filters/color-filter-caret-color.html
Comment 6 EWS Watchlist 2018-04-29 23:38:59 PDT 
Created attachment 339106 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 7 Ryan Haddad 2018-05-01 11:57:13 PDT 
This was landed in https://trac.webkit.org/changeset/231159/webkit

The test added with the change is failing on iOS Simulator as EWS called out above. 
https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r231199%20(4705)/results.html

Simon, can you address this?
Comment 8 Ryan Haddad 2018-05-01 12:41:34 PDT 
Ah, the test name was entered incorrectly in the iOS TestExpectations file. It is missing '.html'
Comment 9 Ryan Haddad 2018-05-01 12:48:18 PDT 
(In reply to Ryan Haddad from comment #8)
> Ah, the test name was entered incorrectly in the iOS TestExpectations file.
> It is missing '.html'
Fixed in https://trac.webkit.org/r231203.