RESOLVED FIXED Bug 185113
Fix color-filter to apply to SVG colors 
https://bugs.webkit.org/show_bug.cgi?id=185113
Summary Fix color-filter to apply to SVG colors
Simon Fraser (smfr)
Reported 2018-04-28 08:30:08 PDT
Fix color-filter to apply to SVG colors
Attachments
Patch (21.16 KB, patch)
2018-04-28 08:42 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.36 MB, application/zip)
2018-04-28 09:47 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.85 MB, application/zip)
2018-04-28 09:52 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews114 for mac-sierra (3.11 MB, application/zip)
2018-04-28 10:18 PDT, EWS Watchlist 		no flags
Details
Patch (21.07 KB, patch)
2018-04-28 10:22 PDT, Simon Fraser (smfr) 		dino: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-sierra (2.34 MB, application/zip)
2018-04-28 11:26 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.85 MB, application/zip)
2018-04-28 11:31 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews113 for mac-sierra (3.10 MB, application/zip)
2018-04-28 11:58 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.37 MB, application/zip)
2018-04-28 12:02 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-04-28 08:41:51 PDT
rdar://problem/39665082
Simon Fraser (smfr)
Comment 2 2018-04-28 08:42:28 PDT
Created attachment 339065 [details] Patch
EWS Watchlist
Comment 3 2018-04-28 09:47:08 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 4 2018-04-28 09:47:10 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 5 2018-04-28 09:52:41 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 6 2018-04-28 09:52:42 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 7 2018-04-28 10:18:39 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 8 2018-04-28 10:18:41 PDT Comment hidden (obsolete)
Simon Fraser (smfr)
Comment 9 2018-04-28 10:22:48 PDT
Created attachment 339070 [details] Patch
EWS Watchlist
Comment 10 2018-04-28 11:26:39 PDT
Comment on attachment 339070 [details] Patch Attachment 339070 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7492622 New failing tests: css3/color-filters/svg/color-filter-inline-svg.html
EWS Watchlist
Comment 11 2018-04-28 11:26:40 PDT
Created attachment 339071 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 12 2018-04-28 11:31:36 PDT
Comment on attachment 339070 [details] Patch Attachment 339070 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7492632 New failing tests: css3/color-filters/svg/color-filter-inline-svg.html
EWS Watchlist
Comment 13 2018-04-28 11:31:38 PDT
Created attachment 339072 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Dean Jackson
Comment 14 2018-04-28 11:49:22 PDT
Comment on attachment 339070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339070&action=review It seems this new test doesn't pass. > Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:239 > + for (Gradient::ColorStop stop : stops) { Nice. > Source/WebCore/svg/SVGFESpecularLightingElement.cpp:123 > + Color color = renderer->style().colorByApplyingColorFilter(renderer->style().svgStyle().lightingColor()); auto. Also, is there any point of having the local variable? > Source/WebCore/svg/SVGFESpecularLightingElement.cpp:205 > + Color color = renderer->style().colorByApplyingColorFilter(renderer->style().svgStyle().lightingColor()); auto > LayoutTests/css3/color-filters/svg/color-filter-inline-svg-expected.html:2 > +<html > wat > LayoutTests/css3/color-filters/svg/color-filter-inline-svg-expected.html:5 > + <link rel="author" title="Apple" href="http://www.apple.com/"> Is this preparing for WPT? > LayoutTests/css3/color-filters/svg/color-filter-inline-svg-expected.html:7 > + <style type="text/css"> no need for type > LayoutTests/css3/color-filters/svg/color-filter-inline-svg-expected.html:15 > +<svg viewBox="0 0 800 600" style="width: 800px; height: 600px"> Why isn't this just an SVG file? Why is it embedded in HTML?
EWS Watchlist
Comment 15 2018-04-28 11:58:01 PDT
Comment on attachment 339070 [details] Patch Attachment 339070 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7492654 New failing tests: css3/color-filters/svg/color-filter-inline-svg.html
EWS Watchlist
Comment 16 2018-04-28 11:58:03 PDT
Created attachment 339073 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 17 2018-04-28 12:02:20 PDT
Comment on attachment 339070 [details] Patch Attachment 339070 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7492655 New failing tests: css3/color-filters/svg/color-filter-inline-svg.html
EWS Watchlist
Comment 18 2018-04-28 12:02:21 PDT
Created attachment 339074 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Simon Fraser (smfr)
Comment 19 2018-04-29 10:38:50 PDT
https://trac.webkit.org/changeset/231153/webkit
Note You need to log in before you can comment on or make changes to this bug.