Bug 185111 - PSON: Make WebKitTestRunner work with process swap on navigation turned on
Summary: PSON: Make WebKitTestRunner work with process swap on navigation turned on
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-28 01:19 PDT by Ryosuke Niwa
Modified: 2018-05-01 21:05 PDT (History)
8 users (show)

See Also:

Attachments
Adds the basic support (31.52 KB, patch)
2018-04-28 01:46 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Updated for ToT (31.48 KB, patch)
2018-04-30 12:15 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Added forgotten WhatToDump.h (33.29 KB, patch)
2018-04-30 13:36 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-04-28 01:19:19 PDT 
Add the basic support for running layout tests with process-swap-on-navigation turned on.
Comment 1 Ryosuke Niwa 2018-04-28 01:46:38 PDT 
Created attachment 339062 [details]
Adds the basic support
Comment 2 Radar WebKit Bug Importer 2018-04-28 01:47:15 PDT 
<rdar://problem/39815667>
Comment 3 Alexey Proskuryakov 2018-04-28 09:12:54 PDT 
What is the performance impact of this change?
Comment 4 Ryosuke Niwa 2018-04-29 11:40:41 PDT 
(In reply to Alexey Proskuryakov from comment #3)
> What is the performance impact of this change?

I'm gonna measure that on Monday. I suspect one extra IPC wouldn't do much but I agree that's one concerning aspect of this change.
Comment 5 Ryosuke Niwa 2018-04-29 11:41:09 PDT 
Comment on attachment 339062 [details]
Adds the basic support

Gotta rebase to trunk :(
Comment 6 Ryosuke Niwa 2018-04-30 12:15:54 PDT 
Created attachment 339135 [details]
Updated for ToT
Comment 7 Ryosuke Niwa 2018-04-30 13:36:54 PDT 
Created attachment 339143 [details]
Added forgotten WhatToDump.h
Comment 8 Ryosuke Niwa 2018-05-01 11:00:07 PDT 
(In reply to Ryosuke Niwa from comment #4)
> (In reply to Alexey Proskuryakov from comment #3)
> > What is the performance impact of this change?
> 
> I'm gonna measure that on Monday. I suspect one extra IPC wouldn't do much
> but I agree that's one concerning aspect of this change.

Appears to be ~1% increase in debug build, which is probably negligible.
Without pach:
Mon Apr 30 19:19:03 PDT 2018
Mon Apr 30 21:23:21 PDT 2018
7458000

With patch:
Mon Apr 30 21:23:57 PDT 2018
Mon Apr 30 23:29:30 PDT 2018
7533000
1% increase

Gonna measure release build next.
Comment 9 Ryosuke Niwa 2018-05-01 19:25:29 PDT 
Without patch:
Tue May  1 12:44:48 PDT 2018
Tue May  1 14:01:22 PDT 2018
4594000

Tue May  1 15:01:39 PDT 2018
Tue May  1 16:18:45 PDT 2018
4626000

~0.6% increase.
Comment 10 Ryosuke Niwa 2018-05-01 20:02:58 PDT 
Ping reviewers?
Comment 11 WebKit Commit Bot 2018-05-01 21:05:46 PDT 
Comment on attachment 339143 [details]
Added forgotten WhatToDump.h

Clearing flags on attachment: 339143

Committed r231222: <https://trac.webkit.org/changeset/231222>
Comment 12 WebKit Commit Bot 2018-05-01 21:05:48 PDT 
All reviewed patches have been landed.  Closing bug.