Bug 185108 – [LFC] Add LayoutTreeBuilder class to generate the layout tree

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

This is temporary though.

[zalan]

Created attachment 339060 [details]
Patch

[Antti Koivisto]

Comment on attachment 339060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339060&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:31030
> -			name = libPAL.a;
> -			path = lib.a;
> +			path = libPAL.a;

wut

> Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:49
> +    std::unique_ptr<Container> initialContainingBlock(new BlockContainer(RenderStyle::clone(renderView.style())));

auto initialContainingBlock = std::make_unique<BlockContainer>(RenderStyle::clone(renderView.style())); 

perhaps?

> Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:50
> +    TreeBuilder::createSubTree(renderView, *initialContainingBlock);

no need fo "TreeBuilder::"

[zalan]

Created attachment 339076 [details]
Patch

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 339060 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339060&action=review
> 
> > Source/WebCore/WebCore.xcodeproj/project.pbxproj:31030
> > -			name = libPAL.a;
> > -			path = lib.a;
> > +			path = libPAL.a;
> 
> wut
Yeah, no idea. I tried adding the files a couple of times in a clean workspace and I always ended up with that change too.

> 
> > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:49
> > +    std::unique_ptr<Container> initialContainingBlock(new BlockContainer(RenderStyle::clone(renderView.style())));
> 
> auto initialContainingBlock =
> std::make_unique<BlockContainer>(RenderStyle::clone(renderView.style())); 
> 
> perhaps?
That's exactly what I did first but that I realized that I need to friend make_unique in addition to TreeBuilder -and I'd rather friend TreeBuilder only.


> > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:50
> > +    TreeBuilder::createSubTree(renderView, *initialContainingBlock);
> 
> no need fo "TreeBuilder::"
Indeed! I originally had this in a different place.

[WebKit Commit Bot]

Comment on attachment 339076 [details]
Patch

Clearing flags on attachment: 339076

Committed r231141: <https://trac.webkit.org/changeset/231141>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39820229>