Bug 185102 - Drop toJS() functions taking a DOMWindow parameter
Summary: Drop toJS() functions taking a DOMWindow parameter
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 185022
Blocks:
  Show dependency tree / graph
 
Reported: 2018-04-27 19:31 PDT by Chris Dumez
Modified: 2018-04-27 21:36 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.85 KB, patch)
2018-04-27 19:36 PDT, Chris Dumez 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-sierra (340.12 KB, application/zip)
2018-04-27 20:35 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews102 for mac-sierra (793.36 KB, application/zip)
2018-04-27 20:47 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews205 for win-future (321.80 KB, application/zip)
2018-04-27 21:22 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-04-27 19:31:44 PDT 
Drop toJS() functions taking a DOMWindow parameter as our implementation should always be returning WindowProxy objects now.
Comment 1 Chris Dumez 2018-04-27 19:36:10 PDT 
Created attachment 339051 [details]
Patch
Comment 2 EWS Watchlist 2018-04-27 20:35:25 PDT 
Comment on attachment 339051 [details]
Patch

Attachment 339051 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7487270

Number of test failures exceeded the failure limit.
Comment 3 EWS Watchlist 2018-04-27 20:35:26 PDT 
Created attachment 339054 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-04-27 20:47:29 PDT 
Comment on attachment 339051 [details]
Patch

Attachment 339051 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7487289

Number of test failures exceeded the failure limit.
Comment 5 EWS Watchlist 2018-04-27 20:47:30 PDT 
Created attachment 339055 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-04-27 21:22:00 PDT 
Comment on attachment 339051 [details]
Patch

Attachment 339051 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7487459

Number of test failures exceeded the failure limit.
Comment 7 EWS Watchlist 2018-04-27 21:22:01 PDT 
Created attachment 339057 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 8 Chris Dumez 2018-04-27 21:36:03 PDT 
Looks like we still need it because of toJS(ExecState*, JSDOMGlobalObject*, EventTarget&).