Bug 185100 – Add logging when SpringBoard enables WebThread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Kilzer (:ddkilzer)]

Add logging when SpringBoard enables WebThread.

<rdar://problem/39746542>

[David Kilzer (:ddkilzer)]

Created attachment 339043 [details]
Patch v1

[Daniel Bates]

Comment on attachment 339043 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=339043&action=review

> Source/WTF/ChangeLog:5
> +        <rdar://problem/39746542>

I assume if I were to look at this bug that it would explain why it is beneficial to add this logging.

> Source/WTF/wtf/Platform.h:-1266
> -/* FIXME: Enable USE_OS_LOG when building with the public iOS 10 SDK once we fix <rdar://problem/27758343>. */

Not at my computer. I am assuming we fixed the referenced radar and hence we can enable this. The ChangeLog didn’t mention this fact and EWS failed to compile this patch for iOS due to another issue below.

> Source/WebCore/platform/ios/wak/WebCoreThread.mm:880
> +        RELEASE_LOG_FAULT(Threading, "SpringBoard enabled WebThread.");

According to the EWS we don’t have a logging channel called Threading.

[David Kilzer (:ddkilzer)]

Comment on attachment 339043 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=339043&action=review

>> Source/WTF/ChangeLog:5
>> +        <rdar://problem/39746542>
> 
> I assume if I were to look at this bug that it would explain why it is beneficial to add this logging.

Correct.  Added more detail just now as well.

>> Source/WTF/wtf/Platform.h:-1266
>> -/* FIXME: Enable USE_OS_LOG when building with the public iOS 10 SDK once we fix <rdar://problem/27758343>. */
> 
> Not at my computer. I am assuming we fixed the referenced radar and hence we can enable this. The ChangeLog didn’t mention this fact and EWS failed to compile this patch for iOS due to another issue below.

Yes, it's fixed.  I'll add a comment to the ChangeLog.

>> Source/WebCore/platform/ios/wak/WebCoreThread.mm:880
>> +        RELEASE_LOG_FAULT(Threading, "SpringBoard enabled WebThread.");
> 
> According to the EWS we don’t have a logging channel called Threading.

Weird.  I thought it was defined here:  Source/WebCore/platform/Logging.h

Maybe I forgot to #include that.

[David Kilzer (:ddkilzer)]

Created attachment 339053 [details]
Patch v2

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #4)
> Created attachment 339053 [details]
> Patch v2

Added missing #import "Logging.h" to WebCoreThread.mm to fix the iOS build failures.

Also updated Source/WTF/ChangeLog with info about the fixed radar.

[WebKit Commit Bot]

Comment on attachment 339053 [details]
Patch v2

Clearing flags on attachment: 339053

Committed r231130: <https://trac.webkit.org/changeset/231130>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.