Bug 185078 - Make MessagePort's close() set [[Detached]]
Summary: Make MessagePort's close() set [[Detached]]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2018-04-27 09:56 PDT by Anne van Kesteren
Modified: 2022-09-19 22:12 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ahmad Saleem 2022-09-17 00:12:23 PDT 
Safari Technology Preview 151 & Chrome Canary 107 still fail these tests:

https://wpt.fyi/results/webmessaging/message-channels/close.any.html?label=master&label=experimental&aligned&view=subtest&q=message%20channel%20close

> close() detaches a MessagePort (but not the one its entangled with)

> close() detaches a MessagePort (but not the one its entangled with)
Comment 2 Alexey Proskuryakov 2022-09-18 16:58:58 PDT 
It may be a good idea to fix this before shipping nested workers, as lifetime issues are even more complicated for those than for first level dedicated workers.
Comment 3 Chris Dumez 2022-09-19 07:45:23 PDT 
No browser passes this particular subtest expect for Firefox.
Comment 4 Chris Dumez 2022-09-19 08:05:24 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4484
Comment 5 EWS 2022-09-19 22:11:57 PDT 
Committed 254661@main (5cc2efcf871d): <https://commits.webkit.org/254661@main>

Reviewed commits have been landed. Closing PR #4484 and removing active labels.
Comment 6 Radar WebKit Bug Importer 2022-09-19 22:12:17 PDT 
<rdar://problem/100156508>