Font::applyTransforms() operates in an increasing-Y-goes-up coordinate system. However, the result of this call is drawn into an increasing-Y-goes-down coordinate system. We need to perform fixup. This was found from the fantastic TYPO Labs 2018 presentation from Ulrike Rausch of LiebeFonts at https://www.typotalks.com/videos/boon-and-bane-of-opentype-features/
<rdar://problem/39778678>
Created attachment 338948 [details] Needs test
Attachment 338948 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 339433 [details] Patch
Attachment 339433 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 339433 [details] Patch Attachment 339433 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7553437 New failing tests: fast/text/vertical-displacement-simple-codepath.html
Created attachment 339439 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 339433 [details] Patch Attachment 339433 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7553491 New failing tests: fast/text/vertical-displacement-simple-codepath.html
Created attachment 339441 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 339433 [details] Patch Attachment 339433 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7553479 New failing tests: fast/text/vertical-displacement-simple-codepath.html
Created attachment 339445 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 339433 [details] Patch Attachment 339433 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7554363 New failing tests: fast/text/vertical-displacement-simple-codepath.html
Created attachment 339458 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 339475 [details] Patch
Attachment 339475 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 339475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339475&action=review > Source/WebCore/platform/graphics/WidthIterator.cpp:118 > + advances[i].setHeight(advances[i].height() * -1); I think unary negation, -x, is a more straightforward way of writing this than multiplying by -1.
Comment on attachment 339475 [details] Patch Attachment 339475 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7561352 New failing tests: imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests21.html
Created attachment 339524 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Committed r231361: <https://trac.webkit.org/changeset/231361>