Bug 185059 - We don't model regexp effects properly
Summary: We don't model regexp effects properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-26 17:06 PDT by Saam Barati
Modified: 2018-04-28 18:17 PDT (History)
15 users (show)

See Also:

Attachments
patch (5.42 KB, patch)
2018-04-26 17:23 PDT, Saam Barati 		fpizlo: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.34 MB, application/zip)
2018-04-26 18:28 PDT, EWS Watchlist 		no flags Details
patch for landing (5.47 KB, patch)
2018-04-27 17:44 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
benchmark results (89.31 KB, text/plain)
2018-04-28 17:50 PDT, Saam Barati 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-04-26 17:06:01 PDT 
...
Comment 1 Saam Barati 2018-04-26 17:22:31 PDT 
<rdar://problem/39736150>
Comment 2 Saam Barati 2018-04-26 17:23:35 PDT 
Created attachment 338940 [details]
patch
Comment 3 Filip Pizlo 2018-04-26 17:43:21 PDT 
Comment on attachment 338940 [details]
patch

Is there a perf cost?
Comment 4 Saam Barati 2018-04-26 18:18:54 PDT 
(In reply to Filip Pizlo from comment #3)
> Comment on attachment 338940 [details]
> patch
> 
> Is there a perf cost?

Don't know, I was planning on running tests before landing this.

If there are, we could have some way of speculating !global
Comment 5 EWS Watchlist 2018-04-26 18:28:44 PDT 
Comment on attachment 338940 [details]
patch

Attachment 338940 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7474769

New failing tests:
accessibility/smart-invert-reference.html
Comment 6 EWS Watchlist 2018-04-26 18:28:46 PDT 
Created attachment 338947 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-04-26 18:41:55 PDT 
Comment on attachment 338940 [details]
patch

Attachment 338940 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/7474754

New failing tests:
stress/materialized-regexp-has-correct-last-index-set-by-match.js.default
stress/materialized-regexp-has-correct-last-index-set-by-match-at-osr-exit.js.default
stress/materialized-regexp-has-correct-last-index-set-by-match-at-osr-exit.js.ftl-no-cjit-validate-sampling-profiler
stress/materialized-regexp-has-correct-last-index-set-by-match-at-osr-exit.js.ftl-no-cjit-no-put-stack-validate
stress/materialized-regexp-has-correct-last-index-set-by-match.js.ftl-no-cjit-validate-sampling-profiler
stress/materialized-regexp-has-correct-last-index-set-by-match.js.ftl-no-cjit-no-put-stack-validate
stress/materialized-regexp-has-correct-last-index-set-by-match-at-osr-exit.js.ftl-eager
stress/materialized-regexp-has-correct-last-index-set-by-match-at-osr-exit.js.ftl-no-cjit-b3o1
stress/materialized-regexp-has-correct-last-index-set-by-match.js.ftl-no-cjit-b3o1
Comment 8 Saam Barati 2018-04-27 17:44:40 PDT 
Created attachment 339044 [details]
patch for landing

This patch should pass tests.

My current benchmarking machine is booked up, but I'll run some benchmarks tonight or tomorrow before landing.
Comment 9 Saam Barati 2018-04-28 17:50:08 PDT 
Created attachment 339083 [details]
benchmark results

looks neutral
Comment 10 WebKit Commit Bot 2018-04-28 18:17:12 PDT 
Comment on attachment 339044 [details]
patch for landing

Clearing flags on attachment: 339044

Committed r231145: <https://trac.webkit.org/changeset/231145>
Comment 11 WebKit Commit Bot 2018-04-28 18:17:13 PDT 
All reviewed patches have been landed.  Closing bug.