Bug 185057 - Style checker has issue with test implementation files with no primary headers
Summary: Style checker has issue with test implementation files with no primary headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 247971
Blocks: 246947
  Show dependency tree / graph
 
Reported: 2018-04-26 15:49 PDT by Megan Gardner
Modified: 2022-11-16 22:18 PST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-04-26 15:49:29 PDT 
If you have a file that does not have a header, like an API test, the style checker will get upset that the first header doesn't match. But there is not header to include, so it should be ok as long as the list is alphabetical after config.h.

I ran into this with SynchronousTimeoutTests.mm
Comment 1 Radar WebKit Bug Importer 2022-10-28 02:30:00 PDT 
<rdar://problem/101670878>
Comment 2 Kimmo Kinnunen 2022-10-28 02:34:07 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5896
Comment 3 EWS 2022-10-29 00:42:05 PDT 
Committed 256128@main (2419e966a284): <https://commits.webkit.org/256128@main>

Reviewed commits have been landed. Closing PR #5896 and removing active labels.
Comment 4 WebKit Commit Bot 2022-11-15 22:54:31 PST 
Re-opened since this is blocked by bug 247971