WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
185057
Style checker has issue with test implementation files with no primary headers
https://bugs.webkit.org/show_bug.cgi?id=185057
Summary
Style checker has issue with test implementation files with no primary headers
Megan Gardner
Reported
2018-04-26 15:49:29 PDT
If you have a file that does not have a header, like an API test, the style checker will get upset that the first header doesn't match. But there is not header to include, so it should be ok as long as the list is alphabetical after config.h. I ran into this with SynchronousTimeoutTests.mm
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-10-28 02:30:00 PDT
<
rdar://problem/101670878
>
Kimmo Kinnunen
Comment 2
2022-10-28 02:34:07 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/5896
EWS
Comment 3
2022-10-29 00:42:05 PDT
Committed
256128@main
(2419e966a284): <
https://commits.webkit.org/256128@main
> Reviewed commits have been landed. Closing PR #5896 and removing active labels.
WebKit Commit Bot
Comment 4
2022-11-15 22:54:31 PST
Re-opened since this is blocked by
bug 247971
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug