Bug 185052 - [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
Summary: [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-26 14:53 PDT by Sihui Liu
Modified: 2018-05-01 09:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.39 KB, patch)
2018-04-27 17:17 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-sierra (3.16 MB, application/zip)
2018-04-27 18:59 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2018-04-26 14:53:33 PDT 
We didn't set the HTTPOnly flag when converting from Cookie to NSHTTPCookie, so the NSHTTPCookie returned by [WKHTTPCookieStore getAllCookies] would always be marked as not HTTPOnly.
Comment 1 Sihui Liu 2018-04-27 17:17:59 PDT 
Created attachment 339042 [details]
Patch
Comment 2 EWS Watchlist 2018-04-27 18:59:06 PDT 
Comment on attachment 339042 [details]
Patch

Attachment 339042 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7486602

New failing tests:
svg/custom/object-sizing-explicit-width.xhtml
Comment 3 EWS Watchlist 2018-04-27 18:59:07 PDT 
Created attachment 339048 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 Geoffrey Garen 2018-04-28 22:00:41 PDT 
Comment on attachment 339042 [details]
Patch

r=me

Hard to tell whether this is an EWS pass or fail. mac-debug looks like a pass, with some pre-existing failures. gtk-wk2 and woe look like the builder needs a reboot. So, I'll say cq+.
Comment 5 WebKit Commit Bot 2018-04-28 22:26:45 PDT 
Comment on attachment 339042 [details]
Patch

Clearing flags on attachment: 339042

Committed r231146: <https://trac.webkit.org/changeset/231146>
Comment 6 WebKit Commit Bot 2018-04-28 22:26:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-04-28 22:27:26 PDT 
<rdar://problem/39821948>