Bug 185049 – [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Stephan Szabo]

[WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case

[Stephan Szabo]

Created attachment 338916 [details]
Patch

[Stephan Szabo]

When setting up the wincairo test machines, we ran into some problems running the JSC tests because previously we had been testing jsc-only windows builds, but those are static JavaScriptCore and WTF, so the necessary DLLs weren't being copied.

While doing that, it was suggested internally that not copying might be better, so added path to allow --no-copy to go from run-javascriptcore-tests to run-jsc-stress-tests and used the jsc location if no framework location was found.

[Keith Miller]

Comment on attachment 338916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338916&action=review

seems reasonable. r=me with some comments.

> Tools/Scripts/run-jsc-stress-tests:1581
> +        if !$remote and !$tarball            

Nit: Please remove this whitespace?

[Stephan Szabo]

Created attachment 339027 [details]
Extraneous whitespace removed

Thanks for pointing out the extra whitespace, this is the same patch it trimmed.

[WebKit Commit Bot]

Comment on attachment 339027 [details]
Extraneous whitespace removed

Rejecting attachment 339027 [details] from commit-queue.

Number of test failures exceeded the failure limit.
Full output: http://webkit-queues.webkit.org/results/7484944

[WebKit Commit Bot]

Created attachment 339034 [details]
Archive of layout-test-results from webkit-cq-02 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-sierra  Platform: Mac OS X 10.12.6

[WebKit Commit Bot]

Comment on attachment 339027 [details]
Extraneous whitespace removed

Clearing flags on attachment: 339027

Committed r231122: <https://trac.webkit.org/changeset/231122>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39810172>