Bug 185037 - Remove WebCore::-qualifier in NetworkLoadChecker.cpp
Summary: Remove WebCore::-qualifier in NetworkLoadChecker.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-26 11:34 PDT by Daniel Bates
Modified: 2018-04-26 11:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.27 KB, patch)
2018-04-26 11:36 PDT, Daniel Bates 		youennf: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-04-26 11:34:08 PDT 
Notice that NetworkLoadChecker.cpp as a "using namespace WebCore" at the top of the file. It is unnecessary to qualify WebCore types following this directive.
Comment 1 Daniel Bates 2018-04-26 11:36:00 PDT 
Created attachment 338899 [details]
Patch
Comment 2 Daniel Bates 2018-04-26 11:37:17 PDT 
Comment on attachment 338899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338899&action=review

> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:183
> +        m_storedCredentialsPolicy = m_isSameOriginRequest && m_origin->canRequest(request.url()) ? StoredCredentialsPolicy::Use : StoredCredentialsPolicy::DoNotUse;

Will add a remark about this change in the ChangeLog before landing. While I was here I noticed there was an extra space character on the right-hand side of the assignment and the parentheses are not necessary in the right-hand side of the assignment.
Comment 3 Daniel Bates 2018-04-26 11:42:13 PDT 
Committed r231060: <https://trac.webkit.org/changeset/231060>
Comment 4 Radar WebKit Bug Importer 2018-04-26 11:43:24 PDT 
<rdar://problem/39765096>