They know what to do.
Created attachment 338881 [details] Patch
Comment on attachment 338881 [details] Patch Attachment 338881 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7474820 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Created attachment 338950 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
(In reply to Build Bot from comment #2) > Comment on attachment 338881 [details] > Patch > > Attachment 338881 [details] did not pass win-ews (win): > Output: http://webkit-queues.webkit.org/results/7474820 > > New failing tests: > http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html Not possible!
Comment on attachment 338881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338881&action=review > Source/WebCore/layout/layouttree/LayoutBox.cpp:140 > + // Initial containing block always establishes a formatting context. > + ASSERT_NOT_REACHED(); > + return nullptr; Could this return Container& instead of *?
Committed r231096: <https://trac.webkit.org/changeset/231096>
<rdar://problem/39792980>
(In reply to Antti Koivisto from comment #5) > Comment on attachment 338881 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338881&action=review > > > Source/WebCore/layout/layouttree/LayoutBox.cpp:140 > > + // Initial containing block always establishes a formatting context. > > + ASSERT_NOT_REACHED(); > > + return nullptr; > > Could this return Container& instead of *? Good point!