RESOLVED FIXED 185032
[LFC] Formatting contexts should create floating states. 
https://bugs.webkit.org/show_bug.cgi?id=185032
Summary [LFC] Formatting contexts should create floating states.
zalan
Reported 2018-04-26 09:37:01 PDT
They know what to do.
Attachments
Patch (21.00 KB, patch)
2018-04-26 09:50 PDT, zalan 		koivisto: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.56 MB, application/zip)
2018-04-26 18:58 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-04-26 09:50:58 PDT
Created attachment 338881 [details] Patch
EWS Watchlist
Comment 2 2018-04-26 18:57:58 PDT
Comment on attachment 338881 [details] Patch Attachment 338881 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7474820 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
EWS Watchlist
Comment 3 2018-04-26 18:58:09 PDT
Created attachment 338950 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
zalan
Comment 4 2018-04-26 19:09:42 PDT
(In reply to Build Bot from comment #2) > Comment on attachment 338881 [details] > Patch > > Attachment 338881 [details] did not pass win-ews (win): > Output: http://webkit-queues.webkit.org/results/7474820 > > New failing tests: > http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html Not possible!
Antti Koivisto
Comment 5 2018-04-27 05:47:30 PDT
Comment on attachment 338881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338881&action=review > Source/WebCore/layout/layouttree/LayoutBox.cpp:140 > + // Initial containing block always establishes a formatting context. > + ASSERT_NOT_REACHED(); > + return nullptr; Could this return Container& instead of *?
zalan
Comment 6 2018-04-27 08:40:23 PDT
Committed r231096: <https://trac.webkit.org/changeset/231096>
Radar WebKit Bug Importer
Comment 7 2018-04-27 08:42:09 PDT
<rdar://problem/39792980>
zalan
Comment 8 2018-04-27 08:55:17 PDT
(In reply to Antti Koivisto from comment #5) > Comment on attachment 338881 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338881&action=review > > > Source/WebCore/layout/layouttree/LayoutBox.cpp:140 > > + // Initial containing block always establishes a formatting context. > > + ASSERT_NOT_REACHED(); > > + return nullptr; > > Could this return Container& instead of *? Good point!
Note You need to log in before you can comment on or make changes to this bug.