RESOLVED FIXED185031
[LFC] Formatting contexts should take const Box& 
https://bugs.webkit.org/show_bug.cgi?id=185031
Summary [LFC] Formatting contexts should take const Box&
alan
Reported 2018-04-26 09:13:02 PDT
and not Box& (because of WeakPtr<>)
Attachments
Patch (7.51 KB, patch)
2018-04-26 09:17 PDT, alan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.59 MB, application/zip)
2018-04-26 11:21 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-04-26 09:17:39 PDT
Created attachment 338878 [details] Patch
EWS Watchlist
Comment 2 2018-04-26 11:21:38 PDT
Comment on attachment 338878 [details] Patch Attachment 338878 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7469611 New failing tests: http/tests/security/contentSecurityPolicy/video-with-http-url-allowed-by-csp-media-src-star.html
EWS Watchlist
Comment 3 2018-04-26 11:21:50 PDT
Created attachment 338896 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
alan
Comment 4 2018-04-26 11:22:14 PDT
(In reply to Build Bot from comment #2) > Comment on attachment 338878 [details] > Patch > > Attachment 338878 [details] did not pass win-ews (win): > Output: http://webkit-queues.webkit.org/results/7469611 > > New failing tests: > http/tests/security/contentSecurityPolicy/video-with-http-url-allowed-by-csp- > media-src-star.html Lie!
WebKit Commit Bot
Comment 5 2018-04-27 07:40:30 PDT
Comment on attachment 338878 [details] Patch Clearing flags on attachment: 338878 Committed r231094: <https://trac.webkit.org/changeset/231094>
WebKit Commit Bot
Comment 6 2018-04-27 07:40:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-04-27 07:42:19 PDT
<rdar://problem/39791616>
Note You need to log in before you can comment on or make changes to this bug.