Bug 185031 - [LFC] Formatting contexts should take const Box&
Summary: [LFC] Formatting contexts should take const Box&
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-26 09:13 PDT by zalan
Modified: 2018-04-27 07:42 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.51 KB, patch)
2018-04-26 09:17 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.59 MB, application/zip)
2018-04-26 11:21 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-04-26 09:13:02 PDT
and not Box& (because of WeakPtr<>)
Comment 1 zalan 2018-04-26 09:17:39 PDT
Created attachment 338878 [details]
Patch
Comment 2 EWS Watchlist 2018-04-26 11:21:38 PDT
Comment on attachment 338878 [details]
Patch

Attachment 338878 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7469611

New failing tests:
http/tests/security/contentSecurityPolicy/video-with-http-url-allowed-by-csp-media-src-star.html
Comment 3 EWS Watchlist 2018-04-26 11:21:50 PDT
Created attachment 338896 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 zalan 2018-04-26 11:22:14 PDT
(In reply to Build Bot from comment #2)
> Comment on attachment 338878 [details]
> Patch
> 
> Attachment 338878 [details] did not pass win-ews (win):
> Output: http://webkit-queues.webkit.org/results/7469611
> 
> New failing tests:
> http/tests/security/contentSecurityPolicy/video-with-http-url-allowed-by-csp-
> media-src-star.html

Lie!
Comment 5 WebKit Commit Bot 2018-04-27 07:40:30 PDT
Comment on attachment 338878 [details]
Patch

Clearing flags on attachment: 338878

Committed r231094: <https://trac.webkit.org/changeset/231094>
Comment 6 WebKit Commit Bot 2018-04-27 07:40:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-04-27 07:42:19 PDT
<rdar://problem/39791616>