Bug 185030 – Token misspelled "tocken" in error message string

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Rick Waldron]

Example: 


SyntaxError: Unexpected escaped characters in keyword tocken: 'aw\u0061it'

[Rick Waldron]

I have a patch coming

[Rick Waldron]

Created attachment 338885 [details]
Fix typo "tocken" => "token" in SyntaxError message string

[Mark Lam]

Comment on attachment 338885 [details]
Fix typo "tocken" => "token" in SyntaxError message string

View in context: https://bugs.webkit.org/attachment.cgi?id=338885&action=review

> JSTests/ChangeLog:390
> -        
> +

Please change your editor to not automatically strip leading spaces like these.  It makes your patch a lot less readable.  Can you please redo your patch without all of these accidental leading space removals?  It's ok to remove some if the leading space is on lines of code immediately adjacent too your changes.  It's not ok to remove all leading spaces elsewhere in the file.  Thanks.

[Rick Waldron]

Created attachment 338888 [details]
Fix typo "tocken" => "token" in SyntaxError message string

[Rick Waldron]

(In reply to Mark Lam from comment #3)
> Comment on attachment 338885 [details]
> Fix typo "tocken" => "token" in SyntaxError message string
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338885&action=review
> 
> > JSTests/ChangeLog:390
> > -        
> > +
> 
> Please change your editor to not automatically strip leading spaces like
> these.  It makes your patch a lot less readable.  Can you please redo your
> patch without all of these accidental leading space removals?  It's ok to
> remove some if the leading space is on lines of code immediately adjacent
> too your changes.  It's not ok to remove all leading spaces elsewhere in the
> file.  Thanks.

Sorry about that—it wasn't my intention to include all the incidental whitespace changes. I've uploaded a corrected patch—Thanks for your patience

[Saam Barati]

Comment on attachment 338888 [details]
Fix typo "tocken" => "token" in SyntaxError message string

oh boy. Thanks for fixing this

r=me

[WebKit Commit Bot]

Comment on attachment 338888 [details]
Fix typo "tocken" => "token" in SyntaxError message string

Clearing flags on attachment: 338888

Committed r231142: <https://trac.webkit.org/changeset/231142>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39820322>