Bug 185030 - Token misspelled "tocken" in error message string
Summary: Token misspelled "tocken" in error message string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-26 09:12 PDT by rwaldron
Modified: 2018-04-28 16:33 PDT (History)
7 users (show)

See Also:


Attachments
Fix typo "tocken" => "token" in SyntaxError message string (131.43 KB, patch)
2018-04-26 10:11 PDT, rwaldron
mark.lam: review-
Details | Formatted Diff | Diff
Fix typo "tocken" => "token" in SyntaxError message string (36.05 KB, patch)
2018-04-26 10:19 PDT, rwaldron
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rwaldron 2018-04-26 09:12:13 PDT
Example: 


SyntaxError: Unexpected escaped characters in keyword tocken: 'aw\u0061it'
Comment 1 rwaldron 2018-04-26 09:24:01 PDT
I have a patch coming
Comment 2 rwaldron 2018-04-26 10:11:57 PDT
Created attachment 338885 [details]
Fix typo "tocken" => "token" in SyntaxError message string
Comment 3 Mark Lam 2018-04-26 10:18:53 PDT
Comment on attachment 338885 [details]
Fix typo "tocken" => "token" in SyntaxError message string

View in context: https://bugs.webkit.org/attachment.cgi?id=338885&action=review

> JSTests/ChangeLog:390
> -        
> +

Please change your editor to not automatically strip leading spaces like these.  It makes your patch a lot less readable.  Can you please redo your patch without all of these accidental leading space removals?  It's ok to remove some if the leading space is on lines of code immediately adjacent too your changes.  It's not ok to remove all leading spaces elsewhere in the file.  Thanks.
Comment 4 rwaldron 2018-04-26 10:19:16 PDT
Created attachment 338888 [details]
Fix typo "tocken" => "token" in SyntaxError message string
Comment 5 rwaldron 2018-04-26 10:21:23 PDT
(In reply to Mark Lam from comment #3)
> Comment on attachment 338885 [details]
> Fix typo "tocken" => "token" in SyntaxError message string
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338885&action=review
> 
> > JSTests/ChangeLog:390
> > -        
> > +
> 
> Please change your editor to not automatically strip leading spaces like
> these.  It makes your patch a lot less readable.  Can you please redo your
> patch without all of these accidental leading space removals?  It's ok to
> remove some if the leading space is on lines of code immediately adjacent
> too your changes.  It's not ok to remove all leading spaces elsewhere in the
> file.  Thanks.

Sorry about that—it wasn't my intention to include all the incidental whitespace changes. I've uploaded a corrected patch—Thanks for your patience
Comment 6 Saam Barati 2018-04-26 10:59:15 PDT
Comment on attachment 338888 [details]
Fix typo "tocken" => "token" in SyntaxError message string

oh boy. Thanks for fixing this

r=me
Comment 7 WebKit Commit Bot 2018-04-28 16:32:32 PDT
Comment on attachment 338888 [details]
Fix typo "tocken" => "token" in SyntaxError message string

Clearing flags on attachment: 338888

Committed r231142: <https://trac.webkit.org/changeset/231142>
Comment 8 WebKit Commit Bot 2018-04-28 16:32:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-04-28 16:33:22 PDT
<rdar://problem/39820322>