Bug 185017 – Activate selection when interacting with editable content

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Activate selection when interacting with editable content

[Megan Gardner]

Created attachment 338833 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/39741847>

[Sam Weinig]

Where are we on being able to test this stuff?

[Radar WebKit Bug Importer]

<rdar://problem/39741913>

[Radar WebKit Bug Importer]

<rdar://problem/39741857>

[Wenson Hsieh]

Comment on attachment 338833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338833&action=review

This looks like a reasonable change to me. It would be great to have a test...

Probably not for this patch, but we should really rename -useSelectionAssistantWithGranularity: to -ensureTextSelectionAssistant or something similar, and drop the selectionGranularity argument.

> Source/WebKit/ChangeLog:10
> +        This fulfills the requirement of user interaction as well, so any javascript selecitons

Nit - selections

[Megan Gardner]

Created attachment 338852 [details]
Patch

[EWS Watchlist]

Comment on attachment 338852 [details]
Patch

Attachment 338852 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7465083

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 338862 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Tim Horton]

Comment on attachment 338852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338852&action=review

> LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html:12
> +        //setTimeout(function(){testRunner.notifyDone()},2000);

What's this!

> LayoutTests/fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html:90
> +            var editableElement =document.getElementById('editable');

Space after = :P

[Megan Gardner]

https://trac.webkit.org/r231054