Bug 185016 - [LFC] Add support for is<> and downcast<>
Summary: [LFC] Add support for is<> and downcast<>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-25 16:53 PDT by zalan
Modified: 2018-04-25 19:11 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.26 KB, patch)
2018-04-25 16:56 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-04-25 16:53:55 PDT 
ssia.
Comment 1 zalan 2018-04-25 16:56:41 PDT 
Created attachment 338828 [details]
Patch
Comment 2 Antti Koivisto 2018-04-25 16:58:32 PDT 
Comment on attachment 338828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338828&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:117
>      bool m_isAnonymous { false };
> +
> +    unsigned m_baseTypeFlags : 3;

Since you are adding a bitfield, you could put m_isAnonymous there as well.
Comment 3 zalan 2018-04-25 19:04:55 PDT 
Committed r231038: <https://trac.webkit.org/changeset/231038>
Comment 4 Radar WebKit Bug Importer 2018-04-25 19:11:57 PDT 
<rdar://problem/39744388>