This doesn't appear to have any impact, since the resulting build settings are the same before and after the change (using `xcodebuild -showBuildSettings`). Just a bit of tidying.
Created attachment 338784 [details] Patch
Comment on attachment 338784 [details] Patch Why is this not just using WK_COCOA_TOUCH the normal way? Why all this notting and emptying?
(In reply to Tim Horton from comment #2) > Comment on attachment 338784 [details] > Patch > > Why is this not just using WK_COCOA_TOUCH the normal way? Why all this > notting and emptying? Good point...perhaps it should be something like this? INSTALL_PATH = $(INSTALL_PATH_$(WK_COCOA_TOUCH)); INSTALL_PATH_cocoatouch = $(WK_ALTERNATE_WEBKIT_SDK_PATH)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks; INSTALL_PATH_ = $(WEBCORE_FRAMEWORKS_DIR);
Yes
Created attachment 338791 [details] Patch
Comment on attachment 338791 [details] Patch Clearing flags on attachment: 338791 Committed r231032: <https://trac.webkit.org/changeset/231032>
All reviewed patches have been landed. Closing bug.