Bug 184985 – [CMake] Require GCC 6

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Michael Catanzaro]

As agreed at https://lists.webkit.org/pipermail/webkit-dev/2018-March/029928.html, it's time to require GCC 6.

[Michael Catanzaro]

(This is going to break the GTK stable bots)

[Michael Catanzaro]

Created attachment 338764 [details]
Patch

[JF Bastien]

Naively this seems good to me, but maybe there's something I'm missing on how exactly we want to do about doing this.

[Alex Christensen]

Comment on attachment 338764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338764&action=review

> Source/WTF/wtf/Compiler.h:-97
> -#if !GCC_VERSION_AT_LEAST(5, 0, 0)
> -#error "Please use a newer version of GCC. WebKit requires GCC 5.0.0 or newer to compile."
> -#endif

Couldn't you just increment this?

[JF Bastien]

(In reply to Alex Christensen from comment #4)
> Comment on attachment 338764 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338764&action=review
> 
> > Source/WTF/wtf/Compiler.h:-97
> > -#if !GCC_VERSION_AT_LEAST(5, 0, 0)
> > -#error "Please use a newer version of GCC. WebKit requires GCC 5.0.0 or newer to compile."
> > -#endif
> 
> Couldn't you just increment this?

It's redundant with the cmake check, but it also doesn't hurt?

[Michael Catanzaro]

(In reply to Alex Christensen from comment #4)
> Comment on attachment 338764 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338764&action=review
> 
> > Source/WTF/wtf/Compiler.h:-97
> > -#if !GCC_VERSION_AT_LEAST(5, 0, 0)
> > -#error "Please use a newer version of GCC. WebKit requires GCC 5.0.0 or newer to compile."
> > -#endif
> 
> Couldn't you just increment this?

Yeah, but it could easily get out of sync with the earlier build system check in the future. I think if XCode build still supports GCC (which seems doubtful?) then it can do its own checking, right?

[JF Bastien]

(In reply to Michael Catanzaro from comment #6)
> (In reply to Alex Christensen from comment #4)
> > Comment on attachment 338764 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=338764&action=review
> > 
> > > Source/WTF/wtf/Compiler.h:-97
> > > -#if !GCC_VERSION_AT_LEAST(5, 0, 0)
> > > -#error "Please use a newer version of GCC. WebKit requires GCC 5.0.0 or newer to compile."
> > > -#endif
> > 
> > Couldn't you just increment this?
> 
> Yeah, but it could easily get out of sync with the earlier build system
> check in the future. I think if XCode build still supports GCC (which seems
> doubtful?) then it can do its own checking, right?

Isn't this a good argument to only keep the Compiler.h check instead?

[Alex Christensen]

We don't support using gcc/Xcode to build WebKit any more.

[Michael Catanzaro]

(In reply to JF Bastien from comment #7)
> Isn't this a good argument to only keep the Compiler.h check instead?

I don't think so, it's better to fail at configure time than to wait until after we've finished building bmalloc and whatever else.

(In reply to Alex Christensen from comment #8)
> We don't support using gcc/Xcode to build WebKit any more.

Then the check in Compiler.h is guaranteed to never be hit, so let's indeed get rid of it.

[EWS Watchlist]

Comment on attachment 338764 [details]
Patch

Attachment 338764 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7460735

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 338834 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Yusuke Suzuki]

Ubuntu LTS 18.04 is released, it's good time to land this :)

[WebKit Commit Bot]

Comment on attachment 338764 [details]
Patch

Clearing flags on attachment: 338764

Committed r231152: <https://trac.webkit.org/changeset/231152>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39825105>