Bug 184983 - [WPE] Should load injected bundle from builddir in developer builds
Summary: [WPE] Should load injected bundle from builddir in developer builds
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Depends on:
Reported: 2018-04-25 11:12 PDT by Michael Catanzaro
Modified: 2018-04-30 08:02 PDT (History)
5 users (show)

See Also:

Patch (1.39 KB, patch)
2018-04-25 13:20 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-04-25 11:12:07 PDT
** (WPEWebProcess:6695): WARNING **: Error loading the injected bundle (/usr/local/lib64/wpe-webkit-0.1/injected-bundle/libWPEInjectedBundle.so): /usr/local/lib64/wpe-webkit-0.1/injected-bundle/libWPEInjectedBundle.so: cannot open shared object file: No such file or directory

It's bonkers that we never noticed this with WebKitGTK+, but we always load the installed injected bundle, never the built version.
Comment 1 Michael Catanzaro 2018-04-25 13:12:06 PDT
Not a problem for GTK. GTK MiniBrowser uses WEBKIT_INJECTED_BUNDLE_PATH to control this.
Comment 2 Michael Catanzaro 2018-04-25 13:20:06 PDT
Created attachment 338777 [details]
Comment 3 WebKit Commit Bot 2018-04-25 14:16:56 PDT
Comment on attachment 338777 [details]

Clearing flags on attachment: 338777

Committed r231021: <https://trac.webkit.org/changeset/231021>
Comment 4 WebKit Commit Bot 2018-04-25 14:16:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Philippe Normand 2018-04-30 02:27:26 PDT
Why is LD_LIBRARY_PATH set only for WPE?
Comment 6 Michael Catanzaro 2018-04-30 08:02:26 PDT
(In reply to Philippe Normand from comment #5)
> Why is LD_LIBRARY_PATH set only for WPE?

It should not be needed because for ELF binaries, CMake sets rpath to point to the build directory when linking (and then zeros it at install time). Otherwise, nothing built by CMake would work before it's installed.