RESOLVED FIXED184983
[WPE] Should load injected bundle from builddir in developer builds 
https://bugs.webkit.org/show_bug.cgi?id=184983
Summary [WPE] Should load injected bundle from builddir in developer builds
Michael Catanzaro
Reported 2018-04-25 11:12:07 PDT
** (WPEWebProcess:6695): WARNING **: Error loading the injected bundle (/usr/local/lib64/wpe-webkit-0.1/injected-bundle/libWPEInjectedBundle.so): /usr/local/lib64/wpe-webkit-0.1/injected-bundle/libWPEInjectedBundle.so: cannot open shared object file: No such file or directory It's bonkers that we never noticed this with WebKitGTK+, but we always load the installed injected bundle, never the built version.
Attachments
Patch (1.39 KB, patch)
2018-04-25 13:20 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-04-25 13:12:06 PDT
Not a problem for GTK. GTK MiniBrowser uses WEBKIT_INJECTED_BUNDLE_PATH to control this.
Michael Catanzaro
Comment 2 2018-04-25 13:20:06 PDT
Created attachment 338777 [details] Patch
WebKit Commit Bot
Comment 3 2018-04-25 14:16:56 PDT
Comment on attachment 338777 [details] Patch Clearing flags on attachment: 338777 Committed r231021: <https://trac.webkit.org/changeset/231021>
WebKit Commit Bot
Comment 4 2018-04-25 14:16:57 PDT
All reviewed patches have been landed. Closing bug.
Philippe Normand
Comment 5 2018-04-30 02:27:26 PDT
Why is LD_LIBRARY_PATH set only for WPE?
Michael Catanzaro
Comment 6 2018-04-30 08:02:26 PDT
(In reply to Philippe Normand from comment #5) > Why is LD_LIBRARY_PATH set only for WPE? It should not be needed because for ELF binaries, CMake sets rpath to point to the build directory when linking (and then zeros it at install time). Otherwise, nothing built by CMake would work before it's installed.
Note You need to log in before you can comment on or make changes to this bug.