Bug 184976 - Push the definition of PtrTag down to the WTF layer.
Summary: Push the definition of PtrTag down to the WTF layer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-25 09:43 PDT by Mark Lam
Modified: 2018-04-26 16:00 PDT (History)
13 users (show)

See Also:

Attachments
proposed patch. (45.16 KB, patch)
2018-04-25 12:57 PDT, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
patch for landing + CMake fixes. (46.28 KB, patch)
2018-04-25 13:39 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-04-25 09:43:42 PDT 
This is in preparation for doing pointer profiling at the WTF later as well.
Comment 1 Radar WebKit Bug Importer 2018-04-25 09:44:52 PDT 
<rdar://problem/39723901>
Comment 2 Mark Lam 2018-04-25 12:57:44 PDT 
Created attachment 338772 [details]
proposed patch.
Comment 3 Mark Lam 2018-04-25 13:39:20 PDT 
Created attachment 338783 [details]
patch for landing + CMake fixes.
Comment 4 Mark Lam 2018-04-25 15:32:03 PDT 
Thanks for the review.  Landed in r231027: <http://trac.webkit.org/r231027>.
Comment 5 Ryan Haddad 2018-04-25 15:57:59 PDT 
This change broke the Windows build:

c:\cygwin\home\buildbot\slave\win-debug\build\source\javascriptcore\runtime\JSCPtrTag.h(56): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj]
c:\cygwin\home\buildbot\slave\win-debug\build\source\javascriptcore\runtime\JSCPtrTag.h(56): warning C4307: '*': integral constant overflow [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj]
c:\cygwin\home\buildbot\slave\win-debug\build\source\javascriptcore\runtime\JSCPtrTag.h(56): warning C4307: '+': integral constant overflow [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\JavaScriptCore\LLIntOffsetsExtractor.vcxproj]

https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/8648
Comment 6 Mark Lam 2018-04-25 17:14:26 PDT 
Landed a speculative build fix for 32-bit Windows in r231035: <http://trac.webkit.org/r231035>.
Comment 7 Mark Lam 2018-04-26 16:00:04 PDT 
(In reply to Mark Lam from comment #6)
> Landed a speculative build fix for 32-bit Windows in r231035:
> <http://trac.webkit.org/r231035>.

New revised speculative build fix for Windows landed in r231079: <http://trac.webkit.org/r231079>.