RESOLVED FIXED 184974
[LFC] Implement Layout::Box functions. 
https://bugs.webkit.org/show_bug.cgi?id=184974
Summary [LFC] Implement Layout::Box functions.
zalan
Reported 2018-04-25 09:17:41 PDT
ssia.
Attachments
Patch (14.81 KB, patch)
2018-04-25 09:29 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (14.93 KB, patch)
2018-04-25 10:12 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-04-25 09:29:15 PDT
Created attachment 338745 [details] Patch
Antti Koivisto
Comment 2 2018-04-25 09:50:47 PDT
Comment on attachment 338745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338745&action=review > Source/WebCore/layout/layouttree/LayoutBox.h:93 > + WeakPtr<RenderElement> m_renderer; I'm not sure that having a pointer to old render objects is good even as a temporary measure. It might get difficult to untangle. > Source/WebCore/layout/layouttree/LayoutBox.h:97 > + WeakPtr<Box> m_nextSibling; > + WeakPtr<Box> m_previousSibling; The basic tree structure probably shouldn't use weak ptrs.
zalan
Comment 3 2018-04-25 10:12:56 PDT
Created attachment 338747 [details] Patch
zalan
Comment 4 2018-04-25 10:49:11 PDT
Committed r230999: <https://trac.webkit.org/changeset/230999>
Radar WebKit Bug Importer
Comment 5 2018-04-25 10:50:25 PDT
<rdar://problem/39726591>
Note You need to log in before you can comment on or make changes to this bug.