Bug 184974 - [LFC] Implement Layout::Box functions.
Summary: [LFC] Implement Layout::Box functions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-25 09:17 PDT by zalan
Modified: 2018-04-25 10:50 PDT (History)
7 users (show)

See Also:

Attachments
Patch (14.81 KB, patch)
2018-04-25 09:29 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (14.93 KB, patch)
2018-04-25 10:12 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-04-25 09:17:41 PDT 
ssia.
Comment 1 zalan 2018-04-25 09:29:15 PDT 
Created attachment 338745 [details]
Patch
Comment 2 Antti Koivisto 2018-04-25 09:50:47 PDT 
Comment on attachment 338745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338745&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:93
> +    WeakPtr<RenderElement> m_renderer;

I'm not sure that having a pointer to old render objects is good even as a temporary measure. It might get difficult to untangle.

> Source/WebCore/layout/layouttree/LayoutBox.h:97
> +    WeakPtr<Box> m_nextSibling;
> +    WeakPtr<Box> m_previousSibling;

The basic tree structure probably shouldn't use weak ptrs.
Comment 3 zalan 2018-04-25 10:12:56 PDT 
Created attachment 338747 [details]
Patch
Comment 4 zalan 2018-04-25 10:49:11 PDT 
Committed r230999: <https://trac.webkit.org/changeset/230999>
Comment 5 Radar WebKit Bug Importer 2018-04-25 10:50:25 PDT 
<rdar://problem/39726591>