Bug 184972 - [CMake] Some options should be marked as advanced
Summary: [CMake] Some options should be marked as advanced
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Keywords: InRadar
Depends on:
Reported: 2018-04-25 08:44 PDT by Michael Catanzaro
Modified: 2018-04-25 12:59 PDT (History)
6 users (show)

See Also:

Patch (2.02 KB, patch)
2018-04-25 09:19 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-04-25 08:44:12 PDT
There are also a couple build options that should be advanced, but are not. BUILD_SHARED is definitely not going to work. LIBGCRYPTCONFIG_SCRIPT and the WEBP options should also be advanced. I'm not sure about USE_CUSTOM_LIBCXX and USE_LIBCXX.
Comment 1 Michael Catanzaro 2018-04-25 09:18:07 PDT
Let's handle BUILD_SHARED, USE_CUSTOM_LIBCXX, and USE_LIBCXX in bug #184973
Comment 2 Michael Catanzaro 2018-04-25 09:19:53 PDT
Created attachment 338744 [details]
Comment 3 WebKit Commit Bot 2018-04-25 12:58:59 PDT
Comment on attachment 338744 [details]

Clearing flags on attachment: 338744

Committed r231012: <https://trac.webkit.org/changeset/231012>
Comment 4 WebKit Commit Bot 2018-04-25 12:59:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-04-25 12:59:18 PDT