Bug 184959 - Incorrect number of WebDriver test failures shown in the bots
Summary: Incorrect number of WebDriver test failures shown in the bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2018-04-24 23:12 PDT by Carlos Garcia Campos
Modified: 2018-04-25 07:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2018-04-24 23:27 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-04-24 23:12:58 PDT 
It's currently reporting 500 failures, while they are actually 40. This is because of the regular expression we are using to parse the output:

re.findall("Unexpected.+\((\d+)\)", logText)

This is now matching a particular test error output:

E           UnexpectedAlertOpenException: unexpected alert open (500):
Comment 1 Carlos Garcia Campos 2018-04-24 23:27:22 PDT 
Created attachment 338710 [details]
Patch
Comment 2 WebKit Commit Bot 2018-04-25 07:19:08 PDT 
Comment on attachment 338710 [details]
Patch

Clearing flags on attachment: 338710

Committed r230993: <https://trac.webkit.org/changeset/230993>
Comment 3 WebKit Commit Bot 2018-04-25 07:19:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-04-25 07:20:20 PDT 
<rdar://problem/39720190>