Bug 184949 - visitedDependentColor() should take a CSSPropertyID
Summary: visitedDependentColor() should take a CSSPropertyID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2018-04-24 18:06 PDT by Simon Fraser (smfr)
Modified: 2018-04-24 18:52 PDT (History)
6 users (show)

See Also:

Patch (10.29 KB, patch)
2018-04-24 18:07 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-04-24 18:06:38 PDT
visitedDependentColor() should take a CSSPropertyID
Comment 1 Simon Fraser (smfr) 2018-04-24 18:07:58 PDT
Created attachment 338693 [details]
Comment 2 Sam Weinig 2018-04-24 18:18:13 PDT
Comment on attachment 338693 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=338693&action=review

> Source/WebCore/rendering/RenderTableCell.cpp:562
> +    CSSPropertyID startColorProperty = includeColor ? CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderStartColor, styleForCellFlow().direction(), styleForCellFlow().writingMode()) : CSSPropertyInvalid;
> +    CSSPropertyID endColorProperty = includeColor ? CSSProperty::resolveDirectionAwareProperty(CSSPropertyWebkitBorderEndColor, styleForCellFlow().direction(), styleForCellFlow().writingMode()) : CSSPropertyInvalid;

You could maybe use auto here (and below), but it's up to you.
Comment 3 WebKit Commit Bot 2018-04-24 18:51:55 PDT
Comment on attachment 338693 [details]

Clearing flags on attachment: 338693

Committed r230979: <https://trac.webkit.org/changeset/230979>
Comment 4 WebKit Commit Bot 2018-04-24 18:51:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-04-24 18:52:16 PDT