Bug 184946 - Move all calls to ResourceLoader::start to WebKitLegacy
Summary: Move all calls to ResourceLoader::start to WebKitLegacy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-24 17:40 PDT by Alex Christensen
Modified: 2018-08-01 20:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.01 KB, patch)
2018-04-24 17:52 PDT, Alex Christensen 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-04-24 17:40:03 PDT 
Move all calls to ResourceLoader::start to WebKitLegacy
Comment 1 Alex Christensen 2018-04-24 17:52:10 PDT 
Created attachment 338691 [details]
Patch
Comment 2 Andy Estes 2018-08-01 14:29:22 PDT 
Comment on attachment 338691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338691&action=review

> Source/WebCore/loader/ResourceLoader.h:155
> +    ResourceRequest takeDeferredRequest() { return std::exchange(m_deferredRequest, ResourceRequest()); }

Can ResourceRequest() be replaced with { }?
Comment 3 Alex Christensen 2018-08-01 15:09:23 PDT 
Yes!
http://trac.webkit.org/r234483
Comment 4 Radar WebKit Bug Importer 2018-08-01 20:22:34 PDT 
<rdar://problem/42840212>