Serialize all URLs with double-quotes per CSSOM spec
Created attachment 338669 [details] Patch
Created attachment 338683 [details] Patch
Comment on attachment 338683 [details] Patch Attachment 338683 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7431512 New failing tests: imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html fast/css/getComputedStyle/computed-style-cross-fade.html fast/events/mouse-cursor.html css3/filters/backdrop/backdropfilter-property-computed-style.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property.html fast/css/cursor-parsing.html css3/filters/filter-property-parsing.html fast/events/mouse-cursor-image-set.html css3/filters/unprefixed.html fast/css/url-with-multi-byte-unicode-escape.html fast/filter-image/parse-filter-image.html fast/shapes/parsing/parsing-shape-outside.html css3/filters/filter-property-computed-style.html fast/css/getComputedStyle/computed-style-border-image.html fast/css/image-set-setting.html imported/w3c/web-platform-tests/cssom/serialize-values.html fast/css/cursor-parsing-image-set.html fast/masking/parsing-clip-path-iri.html svg/css/svg-attribute-parser-mode.html css3/filters/backdrop/backdropfilter-property-parsing.html fast/css/image-set-parsing.html fast/css/uri-token-parsing.html svg/custom/marker-getPropertyValue.svg fast/events/mouse-cursor-multiframecur.html fast/backgrounds/multiple-backgrounds-computed-style.html
Created attachment 338687 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 338694 [details] Update tests
Comment on attachment 338694 [details] Update tests Attachment 338694 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7434870 New failing tests: fast/events/mouse-cursor-image-set.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html fast/css/image-set-parsing.html fast/css/url-with-multi-byte-unicode-escape.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html fast/css/cursor-parsing-image-set.html fast/css/getComputedStyle/computed-style-cross-fade.html fast/events/mouse-cursor-multiframecur.html fast/events/mouse-cursor.html css3/filters/filter-property-parsing.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property.html fast/css/cursor-parsing.html fast/css/image-set-setting.html fast/backgrounds/multiple-backgrounds-computed-style.html
Created attachment 338696 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 338698 [details] Patch
Comment on attachment 338698 [details] Patch Attachment 338698 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7436888 New failing tests: fast/css/image-set-parsing.html fast/css/cursor-parsing-image-set.html imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html fast/css/image-set-setting.html fast/css/cursor-parsing.html
Created attachment 338702 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 338722 [details] Update additional tests
Created attachment 338724 [details] Additional test fixes
Comment on attachment 338724 [details] Additional test fixes Attachment 338724 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7452315 New failing tests: fast/css/parse-border-image-repeat-null-crash.html
Created attachment 338751 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 338754 [details] Update Win expectation
r=me
Comment on attachment 338754 [details] Update Win expectation Rejecting attachment 338754 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 338754, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .txt patching file LayoutTests/resources/image-preload-helper.js patching file LayoutTests/svg/css/svg-attribute-parser-mode-expected.txt patching file LayoutTests/svg/css/svg-attribute-parser-mode.html patching file LayoutTests/svg/custom/marker-getPropertyValue-expected.txt patching file LayoutTests/svg/custom/marker-getPropertyValue.svg Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/7478842
(In reply to WebKit Commit Bot from comment #17) > Comment on attachment 338754 [details] > Update Win expectation > > Rejecting attachment 338754 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', > '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', > 'apply-attachment', '--no-update', '--non-interactive', 338754, > '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > .txt > patching file LayoutTests/resources/image-preload-helper.js > patching file LayoutTests/svg/css/svg-attribute-parser-mode-expected.txt > patching file LayoutTests/svg/css/svg-attribute-parser-mode.html > patching file LayoutTests/svg/custom/marker-getPropertyValue-expected.txt > patching file LayoutTests/svg/custom/marker-getPropertyValue.svg > > Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', > '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: > /Volumes/Data/EWS/WebKit > > Full output: http://webkit-queues.webkit.org/results/7478842 The output doesn't seem to have any reason that the patch was rejected. My guess was some merge conflict, but it applies cleanly locally, so I'm not sure if this is a genuine problem or not.
Created attachment 338982 [details] Try rebasing
The new patch should (hopefully) cleanly apply now.
Antti: maybe we can try this again? I'm hoping to avoid another situation where the patch no longer applies.
Comment on attachment 338982 [details] Try rebasing Clearing flags on attachment: 338982 Committed r231359: <https://trac.webkit.org/changeset/231359>
All reviewed patches have been landed. Closing bug.
<rdar://problem/39980859>