REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure

[Ryan Haddad]

API test WebKit.AutoLayoutIntegration is a flaky failure

FAIL WebKit.AutoLayoutIntegration

/Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:98
Value of: intrinsicContentSize.height
  Actual: 8
Expected: _expectedIntrinsicContentSize.height
Which is: 10

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/9693
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/builds/3431

[Radar WebKit Bug Importer]

<rdar://problem/39705516>

[Ryan Haddad]

The earliest failures I can see from parsing logs on the bots is with https://trac.webkit.org/changeset/230919/webkit, which appears to be unrelated.

Looking at changes around that revision, this seems like it *could* be related: https://trac.webkit.org/changeset/230916/webkit

[Wenson Hsieh]

(In reply to Ryan Haddad from comment #2)
> The earliest failures I can see from parsing logs on the bots is with
> https://trac.webkit.org/changeset/230919/webkit, which appears to be
> unrelated.
> 
> Looking at changes around that revision, this seems like it *could* be
> related: https://trac.webkit.org/changeset/230916/webkit

That change only has an effect when EXTRA_ZOOM_MODE is enabled, so I would not expect that to be related. (i.e., shouldIgnoreScalingConstraintsRegardlessOfContentSize() always returns false in non-extra-zoom-mode).

[Ryan Haddad]

(In reply to Wenson Hsieh from comment #3)
> (In reply to Ryan Haddad from comment #2)
> > The earliest failures I can see from parsing logs on the bots is with
> > https://trac.webkit.org/changeset/230919/webkit, which appears to be
> > unrelated.
> > 
> > Looking at changes around that revision, this seems like it *could* be
> > related: https://trac.webkit.org/changeset/230916/webkit
> 
> That change only has an effect when EXTRA_ZOOM_MODE is enabled, so I would
> not expect that to be related. (i.e.,
> shouldIgnoreScalingConstraintsRegardlessOfContentSize() always returns false
> in non-extra-zoom-mode).
Ok, the search continues.

[Ryan Haddad]

I can reproduce this locally, so I'll try to bisect.

[Ryan Haddad]

This does indeed appear to have regressed with https://trac.webkit.org/changeset/230919/webkit

I cannot reproduce when running this test a few times with a build of r230918, but I can with r230919.

Chris, can you take a look?

[Chris Dumez]

(In reply to Ryan Haddad from comment #6)
> This does indeed appear to have regressed with
> https://trac.webkit.org/changeset/230919/webkit
> 
> I cannot reproduce when running this test a few times with a build of
> r230918, but I can with r230919.
> 
> Chris, can you take a look?

Sure.

[Chris Dumez]

Created attachment 339029 [details]
Patch

[Chris Dumez]

Tim & Wenson: ping review?

[WebKit Commit Bot]

Comment on attachment 339029 [details]
Patch

Clearing flags on attachment: 339029

Committed r231208: <https://trac.webkit.org/changeset/231208>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.