Bug 184910 - Adjust XMLHttpRequest username/password precedence rules
Summary: Adjust XMLHttpRequest username/password precedence rules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-24 02:26 PDT by Anne van Kesteren
Modified: 2018-09-04 13:38 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.96 KB, patch)
2018-09-02 08:13 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (898.91 KB, application/zip)
2018-09-02 09:07 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews100 for mac-sierra (2.31 MB, application/zip)
2018-09-02 09:16 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews204 for win-future (12.82 MB, application/zip)
2018-09-02 09:47 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (13.19 MB, application/zip)
2018-09-02 09:48 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews113 for mac-sierra (3.03 MB, application/zip)
2018-09-02 09:49 PDT, EWS Watchlist
no flags Details
Patch (5.86 KB, patch)
2018-09-02 10:52 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.30 MB, application/zip)
2018-09-02 11:57 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.83 MB, application/zip)
2018-09-02 12:07 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews112 for mac-sierra (3.02 MB, application/zip)
2018-09-02 12:34 PDT, EWS Watchlist
no flags Details
Patch (6.74 KB, patch)
2018-09-02 12:42 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (6.73 KB, patch)
2018-09-04 13:00 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2018-04-24 02:26:59 PDT
See https://github.com/w3c/web-platform-tests/pull/10419.
Comment 1 Rob Buis 2018-09-02 08:13:04 PDT
Created attachment 348730 [details]
Patch
Comment 2 EWS Watchlist 2018-09-02 09:07:21 PDT
Comment on attachment 348730 [details]
Patch

Attachment 348730 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9070546

Number of test failures exceeded the failure limit.
Comment 3 EWS Watchlist 2018-09-02 09:07:23 PDT
Created attachment 348731 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-09-02 09:16:56 PDT
Comment on attachment 348730 [details]
Patch

Attachment 348730 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9070578

New failing tests:
imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm
http/tests/xmlhttprequest/basic-auth.html
Comment 5 EWS Watchlist 2018-09-02 09:16:58 PDT
Created attachment 348732 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-09-02 09:47:41 PDT
Comment on attachment 348730 [details]
Patch

Attachment 348730 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9070690

New failing tests:
http/tests/xmlhttprequest/basic-auth.html
Comment 7 EWS Watchlist 2018-09-02 09:47:52 PDT
Created attachment 348735 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 8 EWS Watchlist 2018-09-02 09:48:40 PDT
Comment on attachment 348730 [details]
Patch

Attachment 348730 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9070600

Number of test failures exceeded the failure limit.
Comment 9 EWS Watchlist 2018-09-02 09:48:44 PDT
Created attachment 348736 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 10 EWS Watchlist 2018-09-02 09:49:19 PDT
Comment on attachment 348730 [details]
Patch

Attachment 348730 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9070639

New failing tests:
imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm
http/tests/xmlhttprequest/basic-auth.html
Comment 11 EWS Watchlist 2018-09-02 09:49:21 PDT
Created attachment 348737 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 12 Rob Buis 2018-09-02 10:52:55 PDT
Created attachment 348739 [details]
Patch
Comment 13 EWS Watchlist 2018-09-02 11:57:36 PDT
Comment on attachment 348739 [details]
Patch

Attachment 348739 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9071576

New failing tests:
imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm
http/tests/xmlhttprequest/basic-auth.html
Comment 14 EWS Watchlist 2018-09-02 11:57:38 PDT
Created attachment 348742 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 15 EWS Watchlist 2018-09-02 12:07:52 PDT
Comment on attachment 348739 [details]
Patch

Attachment 348739 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9071587

New failing tests:
imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm
http/tests/xmlhttprequest/basic-auth.html
Comment 16 EWS Watchlist 2018-09-02 12:07:54 PDT
Created attachment 348744 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 17 EWS Watchlist 2018-09-02 12:34:04 PDT
Comment on attachment 348739 [details]
Patch

Attachment 348739 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9071628

New failing tests:
imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm
http/tests/xmlhttprequest/basic-auth.html
Comment 18 EWS Watchlist 2018-09-02 12:34:06 PDT
Created attachment 348747 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 19 Rob Buis 2018-09-02 12:42:46 PDT
Created attachment 348748 [details]
Patch
Comment 20 Frédéric Wang (:fredw) 2018-09-04 01:00:42 PDT
Comment on attachment 348748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348748&action=review

> Source/WebCore/ChangeLog:8
> +        Step 9.1 and 9.2 in the XMLHTTPRequest::open [1] algorithm

Steps
Comment 21 Rob Buis 2018-09-04 13:00:44 PDT
Created attachment 348842 [details]
Patch
Comment 22 EWS 2018-09-04 13:01:58 PDT
Comment on attachment 348842 [details]
Patch

Rejecting attachment 348842 [details] from commit-queue.

rbuis@igalia.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 23 WebKit Commit Bot 2018-09-04 13:37:37 PDT
Comment on attachment 348842 [details]
Patch

Clearing flags on attachment: 348842

Committed r235631: <https://trac.webkit.org/changeset/235631>
Comment 24 WebKit Commit Bot 2018-09-04 13:37:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 25 Radar WebKit Bug Importer 2018-09-04 13:38:28 PDT
<rdar://problem/44110472>