Bug 184910 – Adjust XMLHttpRequest username/password precedence rules

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anne van Kesteren]

See https://github.com/w3c/web-platform-tests/pull/10419.

[Rob Buis]

Created attachment 348730 [details]
Patch

[EWS Watchlist]

Comment on attachment 348730 [details]
Patch

Attachment 348730 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9070546

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 348731 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 348730 [details]
Patch

Attachment 348730 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9070578

New failing tests:
imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm
http/tests/xmlhttprequest/basic-auth.html

[EWS Watchlist]

Created attachment 348732 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 348730 [details]
Patch

Attachment 348730 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9070690

New failing tests:
http/tests/xmlhttprequest/basic-auth.html

[EWS Watchlist]

Created attachment 348735 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[EWS Watchlist]

Comment on attachment 348730 [details]
Patch

Attachment 348730 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9070600

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 348736 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 348730 [details]
Patch

Attachment 348730 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9070639

New failing tests:
imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm
http/tests/xmlhttprequest/basic-auth.html

[EWS Watchlist]

Created attachment 348737 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Rob Buis]

Created attachment 348739 [details]
Patch

[EWS Watchlist]

Comment on attachment 348739 [details]
Patch

Attachment 348739 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9071576

New failing tests:
imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm
http/tests/xmlhttprequest/basic-auth.html

[EWS Watchlist]

Created attachment 348742 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 348739 [details]
Patch

Attachment 348739 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9071587

New failing tests:
imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm
http/tests/xmlhttprequest/basic-auth.html

[EWS Watchlist]

Created attachment 348744 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 348739 [details]
Patch

Attachment 348739 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9071628

New failing tests:
imported/w3c/web-platform-tests/xhr/send-authentication-competing-names-passwords.htm
http/tests/xmlhttprequest/basic-auth.html

[EWS Watchlist]

Created attachment 348747 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Rob Buis]

Created attachment 348748 [details]
Patch

[Frédéric Wang (:fredw)]

Comment on attachment 348748 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348748&action=review

> Source/WebCore/ChangeLog:8
> +        Step 9.1 and 9.2 in the XMLHTTPRequest::open [1] algorithm

Steps

[Rob Buis]

Created attachment 348842 [details]
Patch

[EWS]

Comment on attachment 348842 [details]
Patch

Rejecting attachment 348842 [details] from commit-queue.

[e-mail] does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 348842 [details]
Patch

Clearing flags on attachment: 348842

Committed r235631: <https://trac.webkit.org/changeset/235631>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44110472>