Bug 18489 - Squirrelfish doesn't build on linux
Summary: Squirrelfish doesn't build on linux
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-14 07:18 PDT by Gabor Loki
Modified: 2008-05-23 05:55 PDT (History)
1 user (show)

See Also:


Attachments
Proposed Squirrelfish build fix for Linux (5.85 KB, patch)
2008-04-14 07:25 PDT, Gabor Loki
ggaren: review+
Details | Formatted Diff | Diff
Build, template, macros fixes for Linux (12.98 KB, patch)
2008-04-29 02:21 PDT, Gabor Loki
mjs: review+
Details | Formatted Diff | Diff
Add missing includes and sources (5.23 KB, patch)
2008-05-15 03:13 PDT, Gabor Loki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2008-04-14 07:18:58 PDT
Currently the squirrelfish branch is not compiled on linux.

The first error looks like:
g++ -c -pipe -Wreturn-type ...
-o tmp/JSBase.o ../../../JavaScriptCore/API/JSBase.cpp
In file included from ../../../JavaScriptCore/kjs/JSGlobalObject.h:26,
                 from ../../../JavaScriptCore/API/JSBase.cpp:32:
../../../JavaScriptCore/kjs/JSVariableObject.h:32:22: error: Register.h: No such
file or directory
... 

Which means there are missing Makefile rules, include headers, etc.

So, I have created a small patch which solves this problem.
At least in my system there are no more build failure.
Comment 1 Gabor Loki 2008-04-14 07:25:37 PDT
Created attachment 20531 [details]
Proposed Squirrelfish build fix for Linux

Let me know if I have missed something.
Comment 2 Geoffrey Garen 2008-04-14 14:58:12 PDT
Comment on attachment 20531 [details]
Proposed Squirrelfish build fix for Linux

Committed revision 31883.

I had to remove tab characters from the ChangeLog. In the future, please use spaces, rather than tabs.
Comment 3 Gabor Loki 2008-04-29 02:21:04 PDT
Created attachment 20886 [details]
Build, template, macros fixes for Linux

This patch is for revision 32670.

The proposed fix contains the followings:
- rename JavaScriptCore/kjs/LocalStorage.h to JavaScriptCore/kjs/LocalStorageEntry.h (like in http://trac.webkit.org/changeset/32259), but I didn't able to update XCode Project file. Please someone (who have a Mac) update this.

- template problem in JavaScriptCore/kjs/collector.{h,cpp}: A new template instance (like in 'allocateNumber') cannot be created only from forward declaration.

- add missing QT_*_NAMESPACE defines (like in http://trac.webkit.org/changeset/32306).

- add some missing includes and sources
Comment 4 Gabor Loki 2008-04-29 02:23:28 PDT
Revision 32670 is not build on Linux (Qt).

I have attached a proposed patch, see my last comment.
Comment 5 Maciej Stachowiak 2008-05-02 04:01:09 PDT
Comment on attachment 20886 [details]
Build, template, macros fixes for Linux

These fixes look good to me.
Comment 6 Gabor Loki 2008-05-15 03:13:06 PDT
Created attachment 21157 [details]
Add missing includes and sources

Revision 33436 is not build on Linux (Qt).

The proposed fix contains the followings:
- Add missing includes
- Remove extra qualification
- Add missing sources to WebCore.pro
Comment 7 Jan Alonzo 2008-05-22 06:18:21 PDT
Hi Gabor

The squirrelfish branch has just been merged into WebKit trunk today. I'm not sure if this patch still applies (gtk port in linux builds fine for example).

Regards
Comment 8 Gabor Loki 2008-05-23 04:45:13 PDT
The squirrelfish branch have been merged.
Qt port is also OK (rev 34071).
Comment 9 Alexey Proskuryakov 2008-05-23 05:55:08 PDT
Comment on attachment 21157 [details]
Add missing includes and sources

Clearing the review flag, so that this doesn't show up in review queue.